Clean up codes

yorkie-team · Oct 23, 2024 · 475276e · 475276e
1 parent ed96982
commit 475276e
Show file tree

Hide file tree

Showing 7 changed files with 173 additions and 176 deletions.
diff --git a/api/docs/yorkie/v1/resources.openapi.yaml b/api/docs/yorkie/v1/resources.openapi.yaml
@@ -259,7 +259,7 @@ components:
         minSyncedTicket:
           $ref: '#/components/schemas/yorkie.v1.TimeTicket'
           additionalProperties: false
-          description: Deprecated
+          description: ""
           title: min_synced_ticket
           type: object
         snapshot:

diff --git a/api/docs/yorkie/v1/yorkie.openapi.yaml b/api/docs/yorkie/v1/yorkie.openapi.yaml
@@ -467,7 +467,7 @@ components:
         minSyncedTicket:
           $ref: '#/components/schemas/yorkie.v1.TimeTicket'
           additionalProperties: false
-          description: Deprecated
+          description: ""
           title: min_synced_ticket
           type: object
         snapshot:

diff --git a/api/yorkie/v1/admin.pb.go b/api/yorkie/v1/admin.pb.go
diff --git a/api/yorkie/v1/admin.proto b/api/yorkie/v1/admin.proto
@@ -156,12 +156,12 @@ message RemoveDocumentByAdminResponse {}
 message GetSnapshotMetaRequest {
   string project_name = 1;
   string document_key = 2;
-  int64 server_seq = 3  [jstype = JS_STRING];
+  int64 server_seq = 3;
 }
 
 message GetSnapshotMetaResponse {
   bytes snapshot = 1;
-  int64 lamport = 2  [jstype = JS_STRING];
+  int64 lamport = 2;
   VersionVector version_vector = 3;
 }
 
@@ -179,7 +179,7 @@ message SearchDocumentsResponse {
 message ListChangesRequest {
   string project_name = 1;
   string document_key = 2;
-  int64 previous_seq = 3  [jstype = JS_STRING];
+  int64 previous_seq = 3;
   int32  page_size = 4; 
   bool   is_forward = 5;
 }

diff --git a/api/yorkie/v1/resources.pb.go b/api/yorkie/v1/resources.pb.go
diff --git a/api/yorkie/v1/resources.proto b/api/yorkie/v1/resources.proto
@@ -44,10 +44,9 @@ message ChangePack {
   Checkpoint checkpoint = 2;
   bytes snapshot = 3;
   repeated Change changes = 4;
+  TimeTicket min_synced_ticket = 5;
   bool is_removed = 6;
   VersionVector version_vector = 7;
-
-  TimeTicket min_synced_ticket = 5; // Deprecated
 }
 
 message Change {

diff --git a/cmd/yorkie/migration.go b/cmd/yorkie/migration.go
@@ -128,8 +128,7 @@ func getMigrationVersionsInRange(from, to string) ([]string, error) {
 	sort.Slice(versions, func(i, j int) bool {
 		compare, err := compareVersions(versions[i], versions[j])
 		if err != nil {
-			fmt.Printf("Error comparing versions: %v\n", err)
-			return false
+			panic(fmt.Errorf("error comparing versions: %w", err))
 		}
 		return compare == -1
 	})