Skip to content

Commit

Permalink
Change parameter name from housekeepingLastProjectID to `lastProjec…
Browse files Browse the repository at this point in the history 
…tID`
  • Loading branch information
JongBeom Lee committed Jan 8, 2024
1 parent 9c0bee4 commit 0ea19bb
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion server/backend/database/database.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ type Database interface {
FindNextNCyclingProjectInfos(
_ context.Context,
pageSize int,
housekeepingLastProjectID types.ID,
lastProjectId types.ID,

Check failure on line 141 in server/backend/database/database.go

View workflow job for this annotation

GitHub Actions / build 

var-naming: interface method parameter lastProjectId should be lastProjectID (revive)
) ([]*ProjectInfo, error)

// FindDeactivateCandidatesPerProject finds the clients that need housekeeping per project.
Expand Down
4 changes: 2 additions & 2 deletions server/backend/database/mongo/client.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -244,9 +244,9 @@ func (c *Client) CreateProjectInfo(
func (c *Client) FindNextNCyclingProjectInfos(
ctx context.Context,
pageSize int,
housekeepingLastProjectID types.ID,
lastProjectID types.ID,
) ([]*database.ProjectInfo, error) {
encodedID, err := encodeID(housekeepingLastProjectID)
encodedID, err := encodeID(lastProjectID)
if err != nil {
return nil, err
}
Expand Down

1 comment on commit 0ea19bb

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go Benchmark

Benchmark suite Current: 0ea19bb Previous: 371c0bd Ratio
BenchmarkDocument/constructor_test - ns/op 1369 ns/op 1377 ns/op 0.99
BenchmarkDocument/constructor_test - B/op 1208 B/op 1208 B/op 1
BenchmarkDocument/constructor_test - allocs/op 20 allocs/op 20 allocs/op 1
BenchmarkDocument/status_test - ns/op 774.7 ns/op 789.4 ns/op 0.98
BenchmarkDocument/status_test - B/op 1176 B/op 1176 B/op 1
BenchmarkDocument/status_test - allocs/op 18 allocs/op 18 allocs/op 1
BenchmarkDocument/equals_test - ns/op 7205 ns/op 7111 ns/op 1.01
BenchmarkDocument/equals_test - B/op 6913 B/op 6913 B/op 1
BenchmarkDocument/equals_test - allocs/op 120 allocs/op 120 allocs/op 1
BenchmarkDocument/nested_update_test - ns/op 18172 ns/op 16193 ns/op 1.12
BenchmarkDocument/nested_update_test - B/op 11963 B/op 11963 B/op 1
BenchmarkDocument/nested_update_test - allocs/op 254 allocs/op 254 allocs/op 1
BenchmarkDocument/delete_test - ns/op 21824 ns/op 21946 ns/op 0.99
BenchmarkDocument/delete_test - B/op 15188 B/op 15188 B/op 1
BenchmarkDocument/delete_test - allocs/op 333 allocs/op 333 allocs/op 1
BenchmarkDocument/object_test - ns/op 8299 ns/op 8312 ns/op 1.00
BenchmarkDocument/object_test - B/op 6721 B/op 6721 B/op 1
BenchmarkDocument/object_test - allocs/op 116 allocs/op 116 allocs/op 1
BenchmarkDocument/array_test - ns/op 28595 ns/op 30000 ns/op 0.95
BenchmarkDocument/array_test - B/op 11819 B/op 11819 B/op 1
BenchmarkDocument/array_test - allocs/op 270 allocs/op 270 allocs/op 1
BenchmarkDocument/text_test - ns/op 31552 ns/op 30139 ns/op 1.05
BenchmarkDocument/text_test - B/op 14795 B/op 14795 B/op 1
BenchmarkDocument/text_test - allocs/op 468 allocs/op 468 allocs/op 1
BenchmarkDocument/text_composition_test - ns/op 28467 ns/op 28335 ns/op 1.00
BenchmarkDocument/text_composition_test - B/op 18276 B/op 18276 B/op 1
BenchmarkDocument/text_composition_test - allocs/op 477 allocs/op 477 allocs/op 1
BenchmarkDocument/rich_text_test - ns/op 79626 ns/op 79995 ns/op 1.00
BenchmarkDocument/rich_text_test - B/op 38540 B/op 38540 B/op 1
BenchmarkDocument/rich_text_test - allocs/op 1147 allocs/op 1147 allocs/op 1
BenchmarkDocument/counter_test - ns/op 16520 ns/op 16569 ns/op 1.00
BenchmarkDocument/counter_test - B/op 10210 B/op 10210 B/op 1
BenchmarkDocument/counter_test - allocs/op 236 allocs/op 236 allocs/op 1
BenchmarkDocument/text_edit_gc_100 - ns/op 2875806 ns/op 2880237 ns/op 1.00
BenchmarkDocument/text_edit_gc_100 - B/op 1655295 B/op 1655338 B/op 1.00
BenchmarkDocument/text_edit_gc_100 - allocs/op 17093 allocs/op 17093 allocs/op 1
BenchmarkDocument/text_edit_gc_1000 - ns/op 228366958 ns/op 230665534 ns/op 0.99
BenchmarkDocument/text_edit_gc_1000 - B/op 144347435 B/op 144353982 B/op 1.00
BenchmarkDocument/text_edit_gc_1000 - allocs/op 200923 allocs/op 200922 allocs/op 1.00
BenchmarkDocument/text_split_gc_100 - ns/op 3345876 ns/op 3364482 ns/op 0.99
BenchmarkDocument/text_split_gc_100 - B/op 2313496 B/op 2313691 B/op 1.00
BenchmarkDocument/text_split_gc_100 - allocs/op 16194 allocs/op 16194 allocs/op 1
BenchmarkDocument/text_split_gc_1000 - ns/op 286313839 ns/op 287958336 ns/op 0.99
BenchmarkDocument/text_split_gc_1000 - B/op 228894372 B/op 228907444 B/op 1.00
BenchmarkDocument/text_split_gc_1000 - allocs/op 203962 allocs/op 204038 allocs/op 1.00
BenchmarkDocument/text_delete_all_10000 - ns/op 10567745 ns/op 10745732 ns/op 0.98
BenchmarkDocument/text_delete_all_10000 - B/op 5809647 B/op 5811042 B/op 1.00
BenchmarkDocument/text_delete_all_10000 - allocs/op 40671 allocs/op 40677 allocs/op 1.00
BenchmarkDocument/text_delete_all_100000 - ns/op 186686978 ns/op 182654438 ns/op 1.02
BenchmarkDocument/text_delete_all_100000 - B/op 81900362 B/op 81901874 B/op 1.00
BenchmarkDocument/text_delete_all_100000 - allocs/op 411625 allocs/op 411632 allocs/op 1.00
BenchmarkDocument/text_100 - ns/op 216730 ns/op 233058 ns/op 0.93
BenchmarkDocument/text_100 - B/op 118483 B/op 118483 B/op 1
BenchmarkDocument/text_100 - allocs/op 5080 allocs/op 5080 allocs/op 1
BenchmarkDocument/text_1000 - ns/op 2348360 ns/op 2391484 ns/op 0.98
BenchmarkDocument/text_1000 - B/op 1153069 B/op 1153070 B/op 1.00
BenchmarkDocument/text_1000 - allocs/op 50084 allocs/op 50084 allocs/op 1
BenchmarkDocument/array_1000 - ns/op 1181212 ns/op 1224286 ns/op 0.96
BenchmarkDocument/array_1000 - B/op 1091237 B/op 1091326 B/op 1.00
BenchmarkDocument/array_1000 - allocs/op 11825 allocs/op 11826 allocs/op 1.00
BenchmarkDocument/array_10000 - ns/op 13035028 ns/op 13077903 ns/op 1.00
BenchmarkDocument/array_10000 - B/op 9798945 B/op 9800290 B/op 1.00
BenchmarkDocument/array_10000 - allocs/op 120286 allocs/op 120292 allocs/op 1.00
BenchmarkDocument/array_gc_100 - ns/op 143452 ns/op 151788 ns/op 0.95
BenchmarkDocument/array_gc_100 - B/op 132490 B/op 132488 B/op 1.00
BenchmarkDocument/array_gc_100 - allocs/op 1248 allocs/op 1248 allocs/op 1
BenchmarkDocument/array_gc_1000 - ns/op 1357479 ns/op 1404854 ns/op 0.97
BenchmarkDocument/array_gc_1000 - B/op 1159008 B/op 1158980 B/op 1.00
BenchmarkDocument/array_gc_1000 - allocs/op 12865 allocs/op 12865 allocs/op 1
BenchmarkDocument/counter_1000 - ns/op 195732 ns/op 206194 ns/op 0.95
BenchmarkDocument/counter_1000 - B/op 192853 B/op 192853 B/op 1
BenchmarkDocument/counter_1000 - allocs/op 5765 allocs/op 5765 allocs/op 1
BenchmarkDocument/counter_10000 - ns/op 2119066 ns/op 2162242 ns/op 0.98
BenchmarkDocument/counter_10000 - B/op 2087765 B/op 2087767 B/op 1.00
BenchmarkDocument/counter_10000 - allocs/op 59772 allocs/op 59772 allocs/op 1
BenchmarkDocument/object_1000 - ns/op 1334674 ns/op 1387175 ns/op 0.96
BenchmarkDocument/object_1000 - B/op 1428007 B/op 1427873 B/op 1.00
BenchmarkDocument/object_1000 - allocs/op 9845 allocs/op 9844 allocs/op 1.00
BenchmarkDocument/object_10000 - ns/op 14869175 ns/op 14940872 ns/op 1.00
BenchmarkDocument/object_10000 - B/op 12166873 B/op 12167844 B/op 1.00
BenchmarkDocument/object_10000 - allocs/op 100561 allocs/op 100565 allocs/op 1.00
BenchmarkDocument/tree_100 - ns/op 1048974 ns/op 1063528 ns/op 0.99
BenchmarkDocument/tree_100 - B/op 943675 B/op 943676 B/op 1.00
BenchmarkDocument/tree_100 - allocs/op 6099 allocs/op 6099 allocs/op 1
BenchmarkDocument/tree_1000 - ns/op 75876287 ns/op 76919106 ns/op 0.99
BenchmarkDocument/tree_1000 - B/op 86460208 B/op 86460483 B/op 1.00
BenchmarkDocument/tree_1000 - allocs/op 60112 allocs/op 60113 allocs/op 1.00
BenchmarkDocument/tree_10000 - ns/op 9365201892 ns/op 9455598211 ns/op 0.99
BenchmarkDocument/tree_10000 - B/op 8580984616 B/op 8580974952 B/op 1.00
BenchmarkDocument/tree_10000 - allocs/op 600248 allocs/op 600241 allocs/op 1.00
BenchmarkDocument/tree_delete_all_1000 - ns/op 71561325 ns/op 76041550 ns/op 0.94
BenchmarkDocument/tree_delete_all_1000 - B/op 86990601 B/op 86990093 B/op 1.00
BenchmarkDocument/tree_delete_all_1000 - allocs/op 67753 allocs/op 67750 allocs/op 1.00
BenchmarkDocument/tree_edit_gc_100 - ns/op 3607374 ns/op 3788184 ns/op 0.95
BenchmarkDocument/tree_edit_gc_100 - B/op 4120999 B/op 4120975 B/op 1.00
BenchmarkDocument/tree_edit_gc_100 - allocs/op 14356 allocs/op 14356 allocs/op 1
BenchmarkDocument/tree_edit_gc_1000 - ns/op 294993585 ns/op 311628432 ns/op 0.95
BenchmarkDocument/tree_edit_gc_1000 - B/op 383465722 B/op 383466072 B/op 1.00
BenchmarkDocument/tree_edit_gc_1000 - allocs/op 145402 allocs/op 145408 allocs/op 1.00
BenchmarkDocument/tree_split_gc_100 - ns/op 2491078 ns/op 2537211 ns/op 0.98
BenchmarkDocument/tree_split_gc_100 - B/op 2386834 B/op 2386834 B/op 1
BenchmarkDocument/tree_split_gc_100 - allocs/op 10341 allocs/op 10341 allocs/op 1
BenchmarkDocument/tree_split_gc_1000 - ns/op 178233671 ns/op 186579060 ns/op 0.96
BenchmarkDocument/tree_split_gc_1000 - B/op 221990420 B/op 221992948 B/op 1.00
BenchmarkDocument/tree_split_gc_1000 - allocs/op 112245 allocs/op 112269 allocs/op 1.00
BenchmarkRPC/client_to_server - ns/op 352171282 ns/op 357207335 ns/op 0.99
BenchmarkRPC/client_to_server - B/op 17802736 B/op 17780002 B/op 1.00
BenchmarkRPC/client_to_server - allocs/op 166878 allocs/op 166893 allocs/op 1.00
BenchmarkRPC/client_to_client_via_server - ns/op 601233770 ns/op 609889492 ns/op 0.99
BenchmarkRPC/client_to_client_via_server - B/op 31690172 B/op 36970424 B/op 0.86
BenchmarkRPC/client_to_client_via_server - allocs/op 312903 allocs/op 312196 allocs/op 1.00
BenchmarkRPC/attach_large_document - ns/op 1338775445 ns/op 1311110292 ns/op 1.02
BenchmarkRPC/attach_large_document - B/op 1878753120 B/op 1890028136 B/op 0.99
BenchmarkRPC/attach_large_document - allocs/op 7568 allocs/op 7522 allocs/op 1.01
BenchmarkRPC/adminCli_to_server - ns/op 532056574 ns/op 542890036 ns/op 0.98
BenchmarkRPC/adminCli_to_server - B/op 35976280 B/op 35988828 B/op 1.00
BenchmarkRPC/adminCli_to_server - allocs/op 289648 allocs/op 289666 allocs/op 1.00
BenchmarkLocker - ns/op 63.99 ns/op 68.75 ns/op 0.93
BenchmarkLocker - B/op 16 B/op 16 B/op 1
BenchmarkLocker - allocs/op 1 allocs/op 1 allocs/op 1
BenchmarkLockerParallel - ns/op 41.36 ns/op 40.48 ns/op 1.02
BenchmarkLockerParallel - B/op 0 B/op 0 B/op NaN
BenchmarkLockerParallel - allocs/op 0 allocs/op 0 allocs/op NaN
BenchmarkLockerMoreKeys - ns/op 146.9 ns/op 147.6 ns/op 1.00
BenchmarkLockerMoreKeys - B/op 15 B/op 15 B/op 1
BenchmarkLockerMoreKeys - allocs/op 0 allocs/op 0 allocs/op NaN
BenchmarkChange/Push_10_Changes - ns/op 3769802 ns/op 3805155 ns/op 0.99
BenchmarkChange/Push_10_Changes - B/op 126436 B/op 126109 B/op 1.00
BenchmarkChange/Push_10_Changes - allocs/op 1254 allocs/op 1248 allocs/op 1.00
BenchmarkChange/Push_100_Changes - ns/op 13988187 ns/op 14183166 ns/op 0.99
BenchmarkChange/Push_100_Changes - B/op 642872 B/op 642196 B/op 1.00
BenchmarkChange/Push_100_Changes - allocs/op 6539 allocs/op 6533 allocs/op 1.00
BenchmarkChange/Push_1000_Changes - ns/op 111513827 ns/op 113839698 ns/op 0.98
BenchmarkChange/Push_1000_Changes - B/op 6082892 B/op 6143264 B/op 0.99
BenchmarkChange/Push_1000_Changes - allocs/op 62164 allocs/op 62159 allocs/op 1.00
BenchmarkChange/Pull_10_Changes - ns/op 2830357 ns/op 2849854 ns/op 0.99
BenchmarkChange/Pull_10_Changes - B/op 101025 B/op 100526 B/op 1.00
BenchmarkChange/Pull_10_Changes - allocs/op 951 allocs/op 952 allocs/op 1.00
BenchmarkChange/Pull_100_Changes - ns/op 4331423 ns/op 4343669 ns/op 1.00
BenchmarkChange/Pull_100_Changes - B/op 258506 B/op 257709 B/op 1.00
BenchmarkChange/Pull_100_Changes - allocs/op 3153 allocs/op 3154 allocs/op 1.00
BenchmarkChange/Pull_1000_Changes - ns/op 8211972 ns/op 8312148 ns/op 0.99
BenchmarkChange/Pull_1000_Changes - B/op 1398440 B/op 1399193 B/op 1.00
BenchmarkChange/Pull_1000_Changes - allocs/op 26876 allocs/op 26872 allocs/op 1.00
BenchmarkSnapshot/Push_3KB_snapshot - ns/op 16624903 ns/op 16961319 ns/op 0.98
BenchmarkSnapshot/Push_3KB_snapshot - B/op 812776 B/op 808475 B/op 1.01
BenchmarkSnapshot/Push_3KB_snapshot - allocs/op 6542 allocs/op 6543 allocs/op 1.00
BenchmarkSnapshot/Push_30KB_snapshot - ns/op 115662235 ns/op 118594721 ns/op 0.98
BenchmarkSnapshot/Push_30KB_snapshot - B/op 6371008 B/op 6352788 B/op 1.00
BenchmarkSnapshot/Push_30KB_snapshot - allocs/op 62172 allocs/op 62161 allocs/op 1.00
BenchmarkSnapshot/Pull_3KB_snapshot - ns/op 6645023 ns/op 6716744 ns/op 0.99
BenchmarkSnapshot/Pull_3KB_snapshot - B/op 906447 B/op 904978 B/op 1.00
BenchmarkSnapshot/Pull_3KB_snapshot - allocs/op 14878 allocs/op 14877 allocs/op 1.00
BenchmarkSnapshot/Pull_30KB_snapshot - ns/op 14650079 ns/op 15139900 ns/op 0.97
BenchmarkSnapshot/Pull_30KB_snapshot - B/op 6985502 B/op 6988512 B/op 1.00
BenchmarkSnapshot/Pull_30KB_snapshot - allocs/op 144138 allocs/op 144138 allocs/op 1
BenchmarkSync/memory_sync_10_test - ns/op 6866 ns/op 6857 ns/op 1.00
BenchmarkSync/memory_sync_10_test - B/op 1286 B/op 1286 B/op 1
BenchmarkSync/memory_sync_10_test - allocs/op 38 allocs/op 38 allocs/op 1
BenchmarkSync/memory_sync_100_test - ns/op 50432 ns/op 52028 ns/op 0.97
BenchmarkSync/memory_sync_100_test - B/op 8660 B/op 8648 B/op 1.00
BenchmarkSync/memory_sync_100_test - allocs/op 274 allocs/op 273 allocs/op 1.00
BenchmarkSync/memory_sync_1000_test - ns/op 580733 ns/op 589322 ns/op 0.99
BenchmarkSync/memory_sync_1000_test - B/op 74586 B/op 74649 B/op 1.00
BenchmarkSync/memory_sync_1000_test - allocs/op 2124 allocs/op 2127 allocs/op 1.00
BenchmarkSync/memory_sync_10000_test - ns/op 7000930 ns/op 7070870 ns/op 0.99
BenchmarkSync/memory_sync_10000_test - B/op 755846 B/op 756421 B/op 1.00
BenchmarkSync/memory_sync_10000_test - allocs/op 20563 allocs/op 20513 allocs/op 1.00
BenchmarkTextEditing - ns/op 18574530989 ns/op 18441616550 ns/op 1.01
BenchmarkTextEditing - B/op 9037802320 B/op 9037573648 B/op 1.00
BenchmarkTextEditing - allocs/op 19923093 allocs/op 19921799 allocs/op 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.