Skip to content

Commit

Permalink
Fix lint errors
Browse files Browse the repository at this point in the history
  • Loading branch information
@devleejb
devleejb committed Jan 9, 2024
1 parent 5ee06cd commit 0c1547f
Showing 1 changed file with 10 additions and 6 deletions.
16 changes: 10 additions & 6 deletions test/integration/housekeeping_test.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,10 @@ import (
"sort"
"testing"

gotime "time"

monkey "github.com/undefinedlabs/go-mpatch"

"github.com/stretchr/testify/assert"
"github.com/yorkie-team/yorkie/api/types"
"github.com/yorkie-team/yorkie/server/backend/database"
Expand Down Expand Up @@ -83,13 +87,13 @@ func TestHousekeeping(t *testing.T) {
log.Fatal(err)
}

clients := activeClients(t, 1)
c3 := clients[0]
defer deactivateAndCloseClients(t, clients)
clients2 := activeClients(t, 1)

Check failure on line 90 in test/integration/housekeeping_test.go

View workflow job for this annotation

GitHub Actions / build 

undefined: activeClients
c3 := clients2[0]
defer deactivateAndCloseClients(t, clients2)

Check failure on line 92 in test/integration/housekeeping_test.go

View workflow job for this annotation

GitHub Actions / build 

undefined: deactivateAndCloseClients

assert.Eqaul(t, c1.IsActive(), false)
assert.Eqaul(t, c2.IsActive(), false)
assert.Eqaul(t, c3.IsActive(), true)
assert.Equal(t, c1.IsActive(), false)
assert.Equal(t, c2.IsActive(), false)
assert.Equal(t, c3.IsActive(), true)
})

t.Run("`FindDeactivateCandidates` should return correct last projectID", func(t *testing.T) {
Expand Down

1 comment on commit 0c1547f

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go Benchmark

Benchmark suite Current: 0c1547f Previous: 371c0bd Ratio
BenchmarkDocument/constructor_test - ns/op 1343 ns/op 1377 ns/op 0.98
BenchmarkDocument/constructor_test - B/op 1208 B/op 1208 B/op 1
BenchmarkDocument/constructor_test - allocs/op 20 allocs/op 20 allocs/op 1
BenchmarkDocument/status_test - ns/op 779 ns/op 789.4 ns/op 0.99
BenchmarkDocument/status_test - B/op 1176 B/op 1176 B/op 1
BenchmarkDocument/status_test - allocs/op 18 allocs/op 18 allocs/op 1
BenchmarkDocument/equals_test - ns/op 7068 ns/op 7111 ns/op 0.99
BenchmarkDocument/equals_test - B/op 6913 B/op 6913 B/op 1
BenchmarkDocument/equals_test - allocs/op 120 allocs/op 120 allocs/op 1
BenchmarkDocument/nested_update_test - ns/op 18407 ns/op 16193 ns/op 1.14
BenchmarkDocument/nested_update_test - B/op 11963 B/op 11963 B/op 1
BenchmarkDocument/nested_update_test - allocs/op 254 allocs/op 254 allocs/op 1
BenchmarkDocument/delete_test - ns/op 21912 ns/op 21946 ns/op 1.00
BenchmarkDocument/delete_test - B/op 15187 B/op 15188 B/op 1.00
BenchmarkDocument/delete_test - allocs/op 333 allocs/op 333 allocs/op 1
BenchmarkDocument/object_test - ns/op 8322 ns/op 8312 ns/op 1.00
BenchmarkDocument/object_test - B/op 6721 B/op 6721 B/op 1
BenchmarkDocument/object_test - allocs/op 116 allocs/op 116 allocs/op 1
BenchmarkDocument/array_test - ns/op 28500 ns/op 30000 ns/op 0.95
BenchmarkDocument/array_test - B/op 11819 B/op 11819 B/op 1
BenchmarkDocument/array_test - allocs/op 270 allocs/op 270 allocs/op 1
BenchmarkDocument/text_test - ns/op 30294 ns/op 30139 ns/op 1.01
BenchmarkDocument/text_test - B/op 14795 B/op 14795 B/op 1
BenchmarkDocument/text_test - allocs/op 468 allocs/op 468 allocs/op 1
BenchmarkDocument/text_composition_test - ns/op 28576 ns/op 28335 ns/op 1.01
BenchmarkDocument/text_composition_test - B/op 18276 B/op 18276 B/op 1
BenchmarkDocument/text_composition_test - allocs/op 477 allocs/op 477 allocs/op 1
BenchmarkDocument/rich_text_test - ns/op 80393 ns/op 79995 ns/op 1.00
BenchmarkDocument/rich_text_test - B/op 38540 B/op 38540 B/op 1
BenchmarkDocument/rich_text_test - allocs/op 1147 allocs/op 1147 allocs/op 1
BenchmarkDocument/counter_test - ns/op 16585 ns/op 16569 ns/op 1.00
BenchmarkDocument/counter_test - B/op 10210 B/op 10210 B/op 1
BenchmarkDocument/counter_test - allocs/op 236 allocs/op 236 allocs/op 1
BenchmarkDocument/text_edit_gc_100 - ns/op 2886490 ns/op 2880237 ns/op 1.00
BenchmarkDocument/text_edit_gc_100 - B/op 1655392 B/op 1655338 B/op 1.00
BenchmarkDocument/text_edit_gc_100 - allocs/op 17093 allocs/op 17093 allocs/op 1
BenchmarkDocument/text_edit_gc_1000 - ns/op 230923943 ns/op 230665534 ns/op 1.00
BenchmarkDocument/text_edit_gc_1000 - B/op 144353470 B/op 144353982 B/op 1.00
BenchmarkDocument/text_edit_gc_1000 - allocs/op 200949 allocs/op 200922 allocs/op 1.00
BenchmarkDocument/text_split_gc_100 - ns/op 3348961 ns/op 3364482 ns/op 1.00
BenchmarkDocument/text_split_gc_100 - B/op 2313435 B/op 2313691 B/op 1.00
BenchmarkDocument/text_split_gc_100 - allocs/op 16192 allocs/op 16194 allocs/op 1.00
BenchmarkDocument/text_split_gc_1000 - ns/op 291383484 ns/op 287958336 ns/op 1.01
BenchmarkDocument/text_split_gc_1000 - B/op 228918684 B/op 228907444 B/op 1.00
BenchmarkDocument/text_split_gc_1000 - allocs/op 204074 allocs/op 204038 allocs/op 1.00
BenchmarkDocument/text_delete_all_10000 - ns/op 10701291 ns/op 10745732 ns/op 1.00
BenchmarkDocument/text_delete_all_10000 - B/op 5811460 B/op 5811042 B/op 1.00
BenchmarkDocument/text_delete_all_10000 - allocs/op 40680 allocs/op 40677 allocs/op 1.00
BenchmarkDocument/text_delete_all_100000 - ns/op 183134330 ns/op 182654438 ns/op 1.00
BenchmarkDocument/text_delete_all_100000 - B/op 81900400 B/op 81901874 B/op 1.00
BenchmarkDocument/text_delete_all_100000 - allocs/op 411618 allocs/op 411632 allocs/op 1.00
BenchmarkDocument/text_100 - ns/op 231797 ns/op 233058 ns/op 0.99
BenchmarkDocument/text_100 - B/op 118483 B/op 118483 B/op 1
BenchmarkDocument/text_100 - allocs/op 5080 allocs/op 5080 allocs/op 1
BenchmarkDocument/text_1000 - ns/op 2476905 ns/op 2391484 ns/op 1.04
BenchmarkDocument/text_1000 - B/op 1153072 B/op 1153070 B/op 1.00
BenchmarkDocument/text_1000 - allocs/op 50084 allocs/op 50084 allocs/op 1
BenchmarkDocument/array_1000 - ns/op 1257335 ns/op 1224286 ns/op 1.03
BenchmarkDocument/array_1000 - B/op 1091304 B/op 1091326 B/op 1.00
BenchmarkDocument/array_1000 - allocs/op 11826 allocs/op 11826 allocs/op 1
BenchmarkDocument/array_10000 - ns/op 13480003 ns/op 13077903 ns/op 1.03
BenchmarkDocument/array_10000 - B/op 9799715 B/op 9800290 B/op 1.00
BenchmarkDocument/array_10000 - allocs/op 120290 allocs/op 120292 allocs/op 1.00
BenchmarkDocument/array_gc_100 - ns/op 153204 ns/op 151788 ns/op 1.01
BenchmarkDocument/array_gc_100 - B/op 132505 B/op 132488 B/op 1.00
BenchmarkDocument/array_gc_100 - allocs/op 1249 allocs/op 1248 allocs/op 1.00
BenchmarkDocument/array_gc_1000 - ns/op 1430877 ns/op 1404854 ns/op 1.02
BenchmarkDocument/array_gc_1000 - B/op 1158988 B/op 1158980 B/op 1.00
BenchmarkDocument/array_gc_1000 - allocs/op 12865 allocs/op 12865 allocs/op 1
BenchmarkDocument/counter_1000 - ns/op 210517 ns/op 206194 ns/op 1.02
BenchmarkDocument/counter_1000 - B/op 192853 B/op 192853 B/op 1
BenchmarkDocument/counter_1000 - allocs/op 5765 allocs/op 5765 allocs/op 1
BenchmarkDocument/counter_10000 - ns/op 2222612 ns/op 2162242 ns/op 1.03
BenchmarkDocument/counter_10000 - B/op 2087768 B/op 2087767 B/op 1.00
BenchmarkDocument/counter_10000 - allocs/op 59772 allocs/op 59772 allocs/op 1
BenchmarkDocument/object_1000 - ns/op 1428916 ns/op 1387175 ns/op 1.03
BenchmarkDocument/object_1000 - B/op 1428085 B/op 1427873 B/op 1.00
BenchmarkDocument/object_1000 - allocs/op 9845 allocs/op 9844 allocs/op 1.00
BenchmarkDocument/object_10000 - ns/op 14873540 ns/op 14940872 ns/op 1.00
BenchmarkDocument/object_10000 - B/op 12165815 B/op 12167844 B/op 1.00
BenchmarkDocument/object_10000 - allocs/op 100558 allocs/op 100565 allocs/op 1.00
BenchmarkDocument/tree_100 - ns/op 1076477 ns/op 1063528 ns/op 1.01
BenchmarkDocument/tree_100 - B/op 943677 B/op 943676 B/op 1.00
BenchmarkDocument/tree_100 - allocs/op 6099 allocs/op 6099 allocs/op 1
BenchmarkDocument/tree_1000 - ns/op 78570261 ns/op 76919106 ns/op 1.02
BenchmarkDocument/tree_1000 - B/op 86459837 B/op 86460483 B/op 1.00
BenchmarkDocument/tree_1000 - allocs/op 60113 allocs/op 60113 allocs/op 1
BenchmarkDocument/tree_10000 - ns/op 10010919290 ns/op 9455598211 ns/op 1.06
BenchmarkDocument/tree_10000 - B/op 8580991032 B/op 8580974952 B/op 1.00
BenchmarkDocument/tree_10000 - allocs/op 600250 allocs/op 600241 allocs/op 1.00
BenchmarkDocument/tree_delete_all_1000 - ns/op 80512461 ns/op 76041550 ns/op 1.06
BenchmarkDocument/tree_delete_all_1000 - B/op 86990049 B/op 86990093 B/op 1.00
BenchmarkDocument/tree_delete_all_1000 - allocs/op 67750 allocs/op 67750 allocs/op 1
BenchmarkDocument/tree_edit_gc_100 - ns/op 3854328 ns/op 3788184 ns/op 1.02
BenchmarkDocument/tree_edit_gc_100 - B/op 4120998 B/op 4120975 B/op 1.00
BenchmarkDocument/tree_edit_gc_100 - allocs/op 14356 allocs/op 14356 allocs/op 1
BenchmarkDocument/tree_edit_gc_1000 - ns/op 326837466 ns/op 311628432 ns/op 1.05
BenchmarkDocument/tree_edit_gc_1000 - B/op 383466388 B/op 383466072 B/op 1.00
BenchmarkDocument/tree_edit_gc_1000 - allocs/op 145409 allocs/op 145408 allocs/op 1.00
BenchmarkDocument/tree_split_gc_100 - ns/op 2635360 ns/op 2537211 ns/op 1.04
BenchmarkDocument/tree_split_gc_100 - B/op 2386887 B/op 2386834 B/op 1.00
BenchmarkDocument/tree_split_gc_100 - allocs/op 10341 allocs/op 10341 allocs/op 1
BenchmarkDocument/tree_split_gc_1000 - ns/op 199422293 ns/op 186579060 ns/op 1.07
BenchmarkDocument/tree_split_gc_1000 - B/op 221990633 B/op 221992948 B/op 1.00
BenchmarkDocument/tree_split_gc_1000 - allocs/op 112255 allocs/op 112269 allocs/op 1.00
BenchmarkRPC/client_to_server - ns/op 357033831 ns/op 357207335 ns/op 1.00
BenchmarkRPC/client_to_server - B/op 18089994 B/op 17780002 B/op 1.02
BenchmarkRPC/client_to_server - allocs/op 166883 allocs/op 166893 allocs/op 1.00
BenchmarkRPC/client_to_client_via_server - ns/op 609062635 ns/op 609889492 ns/op 1.00
BenchmarkRPC/client_to_client_via_server - B/op 32818652 B/op 36970424 B/op 0.89
BenchmarkRPC/client_to_client_via_server - allocs/op 311930 allocs/op 312196 allocs/op 1.00
BenchmarkRPC/attach_large_document - ns/op 1399366969 ns/op 1311110292 ns/op 1.07
BenchmarkRPC/attach_large_document - B/op 1869051232 B/op 1890028136 B/op 0.99
BenchmarkRPC/attach_large_document - allocs/op 7528 allocs/op 7522 allocs/op 1.00
BenchmarkRPC/adminCli_to_server - ns/op 543231194 ns/op 542890036 ns/op 1.00
BenchmarkRPC/adminCli_to_server - B/op 37275752 B/op 35988828 B/op 1.04
BenchmarkRPC/adminCli_to_server - allocs/op 289717 allocs/op 289666 allocs/op 1.00
BenchmarkLocker - ns/op 65.25 ns/op 68.75 ns/op 0.95
BenchmarkLocker - B/op 16 B/op 16 B/op 1
BenchmarkLocker - allocs/op 1 allocs/op 1 allocs/op 1
BenchmarkLockerParallel - ns/op 38.31 ns/op 40.48 ns/op 0.95
BenchmarkLockerParallel - B/op 0 B/op 0 B/op NaN
BenchmarkLockerParallel - allocs/op 0 allocs/op 0 allocs/op NaN
BenchmarkLockerMoreKeys - ns/op 143.1 ns/op 147.6 ns/op 0.97
BenchmarkLockerMoreKeys - B/op 15 B/op 15 B/op 1
BenchmarkLockerMoreKeys - allocs/op 0 allocs/op 0 allocs/op NaN
BenchmarkChange/Push_10_Changes - ns/op 3801825 ns/op 3805155 ns/op 1.00
BenchmarkChange/Push_10_Changes - B/op 126162 B/op 126109 B/op 1.00
BenchmarkChange/Push_10_Changes - allocs/op 1255 allocs/op 1248 allocs/op 1.01
BenchmarkChange/Push_100_Changes - ns/op 14070794 ns/op 14183166 ns/op 0.99
BenchmarkChange/Push_100_Changes - B/op 648188 B/op 642196 B/op 1.01
BenchmarkChange/Push_100_Changes - allocs/op 6538 allocs/op 6533 allocs/op 1.00
BenchmarkChange/Push_1000_Changes - ns/op 113196824 ns/op 113839698 ns/op 0.99
BenchmarkChange/Push_1000_Changes - B/op 5897603 B/op 6143264 B/op 0.96
BenchmarkChange/Push_1000_Changes - allocs/op 62157 allocs/op 62159 allocs/op 1.00
BenchmarkChange/Pull_10_Changes - ns/op 2843725 ns/op 2849854 ns/op 1.00
BenchmarkChange/Pull_10_Changes - B/op 100565 B/op 100526 B/op 1.00
BenchmarkChange/Pull_10_Changes - allocs/op 951 allocs/op 952 allocs/op 1.00
BenchmarkChange/Pull_100_Changes - ns/op 4304459 ns/op 4343669 ns/op 0.99
BenchmarkChange/Pull_100_Changes - B/op 257748 B/op 257709 B/op 1.00
BenchmarkChange/Pull_100_Changes - allocs/op 3154 allocs/op 3154 allocs/op 1
BenchmarkChange/Pull_1000_Changes - ns/op 8552813 ns/op 8312148 ns/op 1.03
BenchmarkChange/Pull_1000_Changes - B/op 1396296 B/op 1399193 B/op 1.00
BenchmarkChange/Pull_1000_Changes - allocs/op 26872 allocs/op 26872 allocs/op 1
BenchmarkSnapshot/Push_3KB_snapshot - ns/op 17245295 ns/op 16961319 ns/op 1.02
BenchmarkSnapshot/Push_3KB_snapshot - B/op 804229 B/op 808475 B/op 0.99
BenchmarkSnapshot/Push_3KB_snapshot - allocs/op 6542 allocs/op 6543 allocs/op 1.00
BenchmarkSnapshot/Push_30KB_snapshot - ns/op 118824697 ns/op 118594721 ns/op 1.00
BenchmarkSnapshot/Push_30KB_snapshot - B/op 6396380 B/op 6352788 B/op 1.01
BenchmarkSnapshot/Push_30KB_snapshot - allocs/op 62171 allocs/op 62161 allocs/op 1.00
BenchmarkSnapshot/Pull_3KB_snapshot - ns/op 6742004 ns/op 6716744 ns/op 1.00
BenchmarkSnapshot/Pull_3KB_snapshot - B/op 904045 B/op 904978 B/op 1.00
BenchmarkSnapshot/Pull_3KB_snapshot - allocs/op 14873 allocs/op 14877 allocs/op 1.00
BenchmarkSnapshot/Pull_30KB_snapshot - ns/op 15210801 ns/op 15139900 ns/op 1.00
BenchmarkSnapshot/Pull_30KB_snapshot - B/op 6979356 B/op 6988512 B/op 1.00
BenchmarkSnapshot/Pull_30KB_snapshot - allocs/op 144139 allocs/op 144138 allocs/op 1.00
BenchmarkSync/memory_sync_10_test - ns/op 6830 ns/op 6857 ns/op 1.00
BenchmarkSync/memory_sync_10_test - B/op 1286 B/op 1286 B/op 1
BenchmarkSync/memory_sync_10_test - allocs/op 38 allocs/op 38 allocs/op 1
BenchmarkSync/memory_sync_100_test - ns/op 52103 ns/op 52028 ns/op 1.00
BenchmarkSync/memory_sync_100_test - B/op 8649 B/op 8648 B/op 1.00
BenchmarkSync/memory_sync_100_test - allocs/op 273 allocs/op 273 allocs/op 1
BenchmarkSync/memory_sync_1000_test - ns/op 590903 ns/op 589322 ns/op 1.00
BenchmarkSync/memory_sync_1000_test - B/op 74721 B/op 74649 B/op 1.00
BenchmarkSync/memory_sync_1000_test - allocs/op 2130 allocs/op 2127 allocs/op 1.00
BenchmarkSync/memory_sync_10000_test - ns/op 8229692 ns/op 7070870 ns/op 1.16
BenchmarkSync/memory_sync_10000_test - B/op 759940 B/op 756421 B/op 1.00
BenchmarkSync/memory_sync_10000_test - allocs/op 20488 allocs/op 20513 allocs/op 1.00
BenchmarkTextEditing - ns/op 19758164738 ns/op 18441616550 ns/op 1.07
BenchmarkTextEditing - B/op 9038462720 B/op 9037573648 B/op 1.00
BenchmarkTextEditing - allocs/op 19923236 allocs/op 19921799 allocs/op 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.