Skip to content

Commit

Permalink
Remove link at Clone
Browse files Browse the repository at this point in the history
  • Loading branch information
@MoonGyu1
MoonGyu1 committed Aug 25, 2023
1 parent 2fa0a56 commit 0293c8d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion design/tree.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ In the case of local editing, the given `index`es are converted to `CRDTTree.Tre

2-1. For text nodes, if necessary, split nodes at the appropriate positions to find the left sibling node.

2-2. Determine the sequence of nodes and find the appropriate position. Since `Clone`s[링크] of each client might exist in different states, the `findFloorNode` function is used to find the closest node (lower bound).
2-2. Determine the sequence of nodes and find the appropriate position. Since `Clone`s of each client might exist in different states, the `findFloorNode` function is used to find the closest node (lower bound).

**[[STEP 3]](https://github.com/yorkie-team/yorkie/blob/fd3b15c7d2c482464b6c8470339bcc497204114e/pkg/document/crdt/tree.go#L582-L640)** Delete nodes in the range of `fromTreePos` to `toTreePos`

Expand Down

1 comment on commit 0293c8d

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go Benchmark

Benchmark suite Current: 0293c8d Previous: e0e7b17 Ratio
BenchmarkDocument/constructor_test - ns/op 1522 ns/op 1631 ns/op 0.93
BenchmarkDocument/constructor_test - B/op 984 B/op 984 B/op 1
BenchmarkDocument/constructor_test - allocs/op 16 allocs/op 16 allocs/op 1
BenchmarkDocument/status_test - ns/op 1252 ns/op 1568 ns/op 0.80
BenchmarkDocument/status_test - B/op 952 B/op 952 B/op 1
BenchmarkDocument/status_test - allocs/op 14 allocs/op 14 allocs/op 1
BenchmarkDocument/equals_test - ns/op 8730 ns/op 9842 ns/op 0.89
BenchmarkDocument/equals_test - B/op 6192 B/op 6192 B/op 1
BenchmarkDocument/equals_test - allocs/op 106 allocs/op 106 allocs/op 1
BenchmarkDocument/nested_update_test - ns/op 22059 ns/op 25128 ns/op 0.88
BenchmarkDocument/nested_update_test - B/op 11689 B/op 11689 B/op 1
BenchmarkDocument/nested_update_test - allocs/op 248 allocs/op 248 allocs/op 1
BenchmarkDocument/delete_test - ns/op 29480 ns/op 33223 ns/op 0.89
BenchmarkDocument/delete_test - B/op 14914 B/op 14913 B/op 1.00
BenchmarkDocument/delete_test - allocs/op 327 allocs/op 327 allocs/op 1
BenchmarkDocument/object_test - ns/op 10543 ns/op 11854 ns/op 0.89
BenchmarkDocument/object_test - B/op 6449 B/op 6449 B/op 1
BenchmarkDocument/object_test - allocs/op 110 allocs/op 110 allocs/op 1
BenchmarkDocument/array_test - ns/op 35886 ns/op 40251 ns/op 0.89
BenchmarkDocument/array_test - B/op 11545 B/op 11546 B/op 1.00
BenchmarkDocument/array_test - allocs/op 264 allocs/op 264 allocs/op 1
BenchmarkDocument/text_test - ns/op 38735 ns/op 42988 ns/op 0.90
BenchmarkDocument/text_test - B/op 14618 B/op 14618 B/op 1
BenchmarkDocument/text_test - allocs/op 470 allocs/op 470 allocs/op 1
BenchmarkDocument/text_composition_test - ns/op 39143 ns/op 44497 ns/op 0.88
BenchmarkDocument/text_composition_test - B/op 18002 B/op 18002 B/op 1
BenchmarkDocument/text_composition_test - allocs/op 471 allocs/op 471 allocs/op 1
BenchmarkDocument/rich_text_test - ns/op 101643 ns/op 121385 ns/op 0.84
BenchmarkDocument/rich_text_test - B/op 36806 B/op 36807 B/op 1.00
BenchmarkDocument/rich_text_test - allocs/op 1131 allocs/op 1131 allocs/op 1
BenchmarkDocument/counter_test - ns/op 21429 ns/op 24778 ns/op 0.86
BenchmarkDocument/counter_test - B/op 9970 B/op 9971 B/op 1.00
BenchmarkDocument/counter_test - allocs/op 235 allocs/op 235 allocs/op 1
BenchmarkDocument/text_edit_gc_100 - ns/op 3988938 ns/op 4953916 ns/op 0.81
BenchmarkDocument/text_edit_gc_100 - B/op 1552830 B/op 1553154 B/op 1.00
BenchmarkDocument/text_edit_gc_100 - allocs/op 17161 allocs/op 17162 allocs/op 1.00
BenchmarkDocument/text_edit_gc_1000 - ns/op 312840196 ns/op 415539332 ns/op 0.75
BenchmarkDocument/text_edit_gc_1000 - B/op 136645800 B/op 136654077 B/op 1.00
BenchmarkDocument/text_edit_gc_1000 - allocs/op 210773 allocs/op 210807 allocs/op 1.00
BenchmarkDocument/text_split_gc_100 - ns/op 4613607 ns/op 5163744 ns/op 0.89
BenchmarkDocument/text_split_gc_100 - B/op 2217845 B/op 2217867 B/op 1.00
BenchmarkDocument/text_split_gc_100 - allocs/op 16591 allocs/op 16589 allocs/op 1.00
BenchmarkDocument/text_split_gc_1000 - ns/op 370229904 ns/op 459261506 ns/op 0.81
BenchmarkDocument/text_split_gc_1000 - B/op 214825789 B/op 214825368 B/op 1.00
BenchmarkDocument/text_split_gc_1000 - allocs/op 211286 allocs/op 211278 allocs/op 1.00
BenchmarkDocument/text_delete_all_10000 - ns/op 15111711 ns/op 21640628 ns/op 0.70
BenchmarkDocument/text_delete_all_10000 - B/op 5904065 B/op 5904350 B/op 1.00
BenchmarkDocument/text_delete_all_10000 - allocs/op 41126 allocs/op 41125 allocs/op 1.00
BenchmarkDocument/text_delete_all_100000 - ns/op 204823303 ns/op 293915504 ns/op 0.70
BenchmarkDocument/text_delete_all_100000 - B/op 53873980 B/op 53849444 B/op 1.00
BenchmarkDocument/text_delete_all_100000 - allocs/op 415992 allocs/op 416019 allocs/op 1.00
BenchmarkDocument/text_100 - ns/op 304305 ns/op 368364 ns/op 0.83
BenchmarkDocument/text_100 - B/op 118213 B/op 118211 B/op 1.00
BenchmarkDocument/text_100 - allocs/op 5074 allocs/op 5074 allocs/op 1
BenchmarkDocument/text_1000 - ns/op 3289177 ns/op 4020698 ns/op 0.82
BenchmarkDocument/text_1000 - B/op 1152813 B/op 1152828 B/op 1.00
BenchmarkDocument/text_1000 - allocs/op 50078 allocs/op 50078 allocs/op 1
BenchmarkDocument/array_1000 - ns/op 1706405 ns/op 1982625 ns/op 0.86
BenchmarkDocument/array_1000 - B/op 1102631 B/op 1102720 B/op 1.00
BenchmarkDocument/array_1000 - allocs/op 11867 allocs/op 11867 allocs/op 1
BenchmarkDocument/array_10000 - ns/op 18548597 ns/op 24133350 ns/op 0.77
BenchmarkDocument/array_10000 - B/op 9907502 B/op 9908265 B/op 1.00
BenchmarkDocument/array_10000 - allocs/op 120722 allocs/op 120725 allocs/op 1.00
BenchmarkDocument/array_gc_100 - ns/op 182381 ns/op 218206 ns/op 0.84
BenchmarkDocument/array_gc_100 - B/op 98154 B/op 98170 B/op 1.00
BenchmarkDocument/array_gc_100 - allocs/op 1243 allocs/op 1243 allocs/op 1
BenchmarkDocument/array_gc_1000 - ns/op 1971940 ns/op 2439002 ns/op 0.81
BenchmarkDocument/array_gc_1000 - B/op 1170373 B/op 1170334 B/op 1.00
BenchmarkDocument/array_gc_1000 - allocs/op 12906 allocs/op 12906 allocs/op 1
BenchmarkDocument/counter_1000 - ns/op 273184 ns/op 348837 ns/op 0.78
BenchmarkDocument/counter_1000 - B/op 198534 B/op 198533 B/op 1.00
BenchmarkDocument/counter_1000 - allocs/op 6503 allocs/op 6503 allocs/op 1
BenchmarkDocument/counter_10000 - ns/op 2919870 ns/op 3797783 ns/op 0.77
BenchmarkDocument/counter_10000 - B/op 2165433 B/op 2165466 B/op 1.00
BenchmarkDocument/counter_10000 - allocs/op 69510 allocs/op 69510 allocs/op 1
BenchmarkDocument/object_1000 - ns/op 1860055 ns/op 2176596 ns/op 0.85
BenchmarkDocument/object_1000 - B/op 1451262 B/op 1451413 B/op 1.00
BenchmarkDocument/object_1000 - allocs/op 9915 allocs/op 9915 allocs/op 1
BenchmarkDocument/object_10000 - ns/op 21117893 ns/op 29075180 ns/op 0.73
BenchmarkDocument/object_10000 - B/op 12367033 B/op 12368142 B/op 1.00
BenchmarkDocument/object_10000 - allocs/op 101210 allocs/op 101216 allocs/op 1.00
BenchmarkRPC/client_to_server - ns/op 383643551 ns/op 623741911 ns/op 0.62
BenchmarkRPC/client_to_server - B/op 12257178 B/op 12446728 B/op 0.98
BenchmarkRPC/client_to_server - allocs/op 177184 allocs/op 177074 allocs/op 1.00
BenchmarkRPC/client_to_client_via_server - ns/op 655664818 ns/op 1007493091 ns/op 0.65
BenchmarkRPC/client_to_client_via_server - B/op 22596328 B/op 22360952 B/op 1.01
BenchmarkRPC/client_to_client_via_server - allocs/op 330932 allocs/op 315734 allocs/op 1.05
BenchmarkRPC/attach_large_document - ns/op 1627228824 ns/op 1462175961 ns/op 1.11
BenchmarkRPC/attach_large_document - B/op 1809738816 B/op 1799019544 B/op 1.01
BenchmarkRPC/attach_large_document - allocs/op 9722 allocs/op 9450 allocs/op 1.03
BenchmarkRPC/adminCli_to_server - ns/op 496945021 ns/op 824637910 ns/op 0.60
BenchmarkRPC/adminCli_to_server - B/op 20279602 B/op 20415996 B/op 0.99
BenchmarkRPC/adminCli_to_server - allocs/op 321444 allocs/op 321647 allocs/op 1.00
BenchmarkLocker - ns/op 113 ns/op 144.4 ns/op 0.78
BenchmarkLocker - B/op 16 B/op 16 B/op 1
BenchmarkLocker - allocs/op 1 allocs/op 1 allocs/op 1
BenchmarkLockerParallel - ns/op 111.4 ns/op 142.7 ns/op 0.78
BenchmarkLockerParallel - B/op 0 B/op 0 B/op NaN
BenchmarkLockerParallel - allocs/op 0 allocs/op 0 allocs/op NaN
BenchmarkLockerMoreKeys - ns/op 350.4 ns/op 330.2 ns/op 1.06
BenchmarkLockerMoreKeys - B/op 14 B/op 15 B/op 0.93
BenchmarkLockerMoreKeys - allocs/op 0 allocs/op 0 allocs/op NaN
BenchmarkSync/memory_sync_10_test - ns/op 7086 ns/op 8751 ns/op 0.81
BenchmarkSync/memory_sync_10_test - B/op 1286 B/op 1284 B/op 1.00
BenchmarkSync/memory_sync_10_test - allocs/op 38 allocs/op 38 allocs/op 1
BenchmarkSync/memory_sync_100_test - ns/op 58389 ns/op 79832 ns/op 0.73
BenchmarkSync/memory_sync_100_test - B/op 9086 B/op 8908 B/op 1.02
BenchmarkSync/memory_sync_100_test - allocs/op 301 allocs/op 289 allocs/op 1.04
BenchmarkSync/memory_sync_1000_test - ns/op 633320 ns/op 763146 ns/op 0.83
BenchmarkSync/memory_sync_1000_test - B/op 84402 B/op 82936 B/op 1.02
BenchmarkSync/memory_sync_1000_test - allocs/op 2743 allocs/op 2647 allocs/op 1.04
BenchmarkSync/memory_sync_10000_test - ns/op 6772394 ns/op 8311071 ns/op 0.81
BenchmarkSync/memory_sync_10000_test - B/op 873498 B/op 879987 B/op 0.99
BenchmarkSync/memory_sync_10000_test - allocs/op 27771 allocs/op 28295 allocs/op 0.98
BenchmarkTextEditing - ns/op 24730662764 ns/op 32727791991 ns/op 0.76
BenchmarkTextEditing - B/op 8457380032 B/op 8456442864 B/op 1.00
BenchmarkTextEditing - allocs/op 20616689 allocs/op 20611911 allocs/op 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.