Update exmples version to v0.4.20 #822
Conversation
|
Warning Rate Limit Exceeded@chacha912 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 50 minutes and 0 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe updates primarily involve incrementing the version of the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #822 +/- ##
=======================================
Coverage 80.41% 80.41%
=======================================
Files 59 59
Lines 4535 4535
Branches 918 918
=======================================
Hits 3647 3647
Misses 620 620
Partials 268 268 ☔ View full report in Codecov by Sentry. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Outside diff range and nitpick comments (2)
examples/vanilla-codemirror6/src/main.ts (2)
Line range hint
20-24: Avoid using non-null assertions. Consider adding null checks or using optional chaining.- const editorParentElem = document.getElementById('editor')!; - const peersElem = document.getElementById('peers')!; - const documentElem = document.getElementById('document')!; - const documentTextElem = document.getElementById('document-text')!; - const networkStatusElem = document.getElementById('network-status')!; + const editorParentElem = document.getElementById('editor'); + const peersElem = document.getElementById('peers'); + const documentElem = document.getElementById('document'); + const documentTextElem = document.getElementById('document-text'); + const networkStatusElem = document.getElementById('network-status'); + if (!editorParentElem || !peersElem || !documentElem || !documentTextElem || !networkStatusElem) { + throw new Error('One or more essential elements are missing in the DOM'); + }
Line range hint
131-131: Avoid using non-null assertions. Consider adding null checks or using optional chaining.- insert: op.value!.content, + insert: op.value?.content ?? '',
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
Files selected for processing (10)
- examples/nextjs-scheduler/package.json (1 hunks)
- examples/profile-stack/package.json (1 hunks)
- examples/react-tldraw/package.json (1 hunks)
- examples/react-todomvc/package.json (1 hunks)
- examples/simultaneous-cursors/package.json (1 hunks)
- examples/vanilla-codemirror6/package.json (1 hunks)
- examples/vanilla-codemirror6/src/main.ts (2 hunks)
- examples/vanilla-quill/package.json (1 hunks)
- examples/vuejs-kanban/package.json (1 hunks)
- public/quill.html (1 hunks)
Files skipped from review due to trivial changes (8)
- examples/nextjs-scheduler/package.json
- examples/profile-stack/package.json
- examples/react-tldraw/package.json
- examples/react-todomvc/package.json
- examples/simultaneous-cursors/package.json
- examples/vanilla-codemirror6/package.json
- examples/vanilla-quill/package.json
- examples/vuejs-kanban/package.json
Additional Context Used
Biome (10)
examples/vanilla-codemirror6/src/main.ts (10)
20-20: Forbidden non-null assertion.
21-21: Forbidden non-null assertion.
22-22: Forbidden non-null assertion.
23-23: Forbidden non-null assertion.
24-24: Forbidden non-null assertion.
48-48: Forbidden non-null assertion.
120-124: Prefer for...of instead of forEach.
131-131: Forbidden non-null assertion.
1-6: Some named imports are only used as types.
16-17: All these imports are only used as types.
Additional comments not posted (1)
public/quill.html (1)
74-77: Ensure that theNetworkinstance is properly initialized withnetworkStatusElembefore using it indoc.subscribe.Verification successful
The
Networkclass constructor inpublic/util.jsproperly initializes theelemparameter, storing it inthis.elemand using it in methods to update the network status. This confirms that theNetworkinstance is correctly initialized withnetworkStatusElembefore being used indoc.subscribe.
public/util.js:
class Network:
constructor(elem): Initializesthis.elemwithelem.Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the initialization of `Network` instance with `networkStatusElem`. # Test: Search for the `Network` class definition and its constructor usage. Expect: Proper handling of `networkStatusElem`. rg --type html --type js 'new Network\('Length of output: 623
Script:
#!/bin/bash # Description: Locate the `Network` class definition and inspect its constructor. # Test: Search for the `Network` class definition and extract its constructor. ast-grep --lang javascript --pattern $'class Network { constructor($_) { $$$ } }'Length of output: 90
Script:
#!/bin/bash # Description: Locate the `Network` class definition and inspect its constructor. # Step 1: Search for the `class Network` definition across the codebase. rg --type js 'class Network' # Step 2: If found, extract the constructor of the `Network` class. # Note: This step will be executed only if the first step finds the class definition. rg --type js --after-context=10 'class Network' | rg 'constructor'Length of output: 165
Script:
#!/bin/bash # Description: Extract the full constructor implementation of the `Network` class from `public/util.js`. # Extract the full constructor implementation of the `Network` class. rg --type js --context=10 'constructor(elem)' public/util.jsLength of output: 62
Script:
#!/bin/bash # Description: Extract the full constructor implementation of the `Network` class from `public/util.js`. # Extract the full constructor implementation of the `Network` class with increased context lines. rg --type js --context=20 'class Network' public/util.jsLength of output: 501
What this PR does / why we need it?
Update exmples version to v0.4.20
Any background context you want to provide?
What are the relevant tickets?
Fixes #
Checklist
Summary by CodeRabbit
Dependencies
yorkie-js-sdkdependency version from^0.4.19to^0.4.20across various examples (nextjs-scheduler, profile-stack, react-tldraw, react-todomvc, simultaneous-cursors, vanilla-codemirror6, vuejs-kanban).Enhancements
vanilla-codemirror6by updating imports and function parameters to use specific types fromyorkie-js-sdk.Bug Fixes
public/quill.htmlto use a new parameter forNetworkinstance creation, ensuring proper event handling.