Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vitest single thread config #667

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

blurfx
Copy link
Member

@blurfx blurfx commented Oct 13, 2023

What this PR does / why we need it?

Let vitest use multi threads to reduce the time it takes.

The test took about 20% less time(~90s to ~70s) in my local environment.

Any background context you want to provide?

What are the relevant tickets?

Fixes #654 #665

Checklist

  • Added relevant tests or not required
  • Didn't break anything

@blurfx blurfx self-assigned this Oct 13, 2023
@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (c4938f7) 71.38% compared to head (9cfe1be) 67.83%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #667      +/-   ##
==========================================
- Coverage   71.38%   67.83%   -3.55%     
==========================================
  Files          58       58              
  Lines        8734     8734              
  Branches      784      784              
==========================================
- Hits         6235     5925     -310     
- Misses       2241     2550     +309     
- Partials      258      259       +1     

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blurfx
Copy link
Member Author

blurfx commented Oct 13, 2023

It's slower in actions test environment.. 🤔

@hackerwins hackerwins self-requested a review October 13, 2023 06:34
@hackerwins
Copy link
Member

It took only 8s in my local environment.

Before:
Screenshot 2023-10-13 at 3 35 53 PM

After:
Screenshot 2023-10-13 at 3 32 43 PM

Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

@hackerwins hackerwins merged commit 918b215 into yorkie-team:main Oct 13, 2023
@hackerwins hackerwins changed the title feat: remove vitest single thread config Remove vitest single thread config Oct 13, 2023
@blurfx blurfx deleted the feat/vitest-multi-theads branch October 13, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestion: migrate karma to a another test framework
2 participants