feat: switching test framework to vitest #655
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blurfx
force-pushed
the
feat/vitest
branch
3 times, most recently
from
34ad02f to
d8769dc
Compare
2 tasks
hackerwins
added a commit
that referenced
this pull request
Oct 13, 2023
karma is deprecated and no longer maintained and It's hard to configure and slower than other modern test frameworks. vitest is one of the fastest modern testing frameworks and can be used with a near-zero configuration, that is why we chose it. For this PR, we did the following things: - Changes from #655 - karma, mocha, sinon and chai are removed and replaced with vitest - Use vi.fn() instead of sinon.spy() - Use vi.fn().mockImplementation instead of sinon.stub().callsFake() - Use task.name instead of this.test!.title to get the title of test - Inject yorkie RPC address for testing as an environment variable - Fix XMLHttpRequest mock. not using sinon anymore - Use a customized jsdom vitest environment to prevent the implementation of the Uint8Array from being overwritten via jsdom --------- Co-authored-by: blurfx <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
Switching test framework to vitest from karma.
karma is deprecated and no longer maintained and It's hard to configure and slower than other modern test frameworks. vitest is one of the fastest modern testing frameworks and can be used with a near-zero configuration, that is why I chose it.
for this pull request, I did the following things:
vi.fn()instead ofsinon.spy()vi.fn().mockImplementationinstead ofsinon.stub().callsFake()task.nameinstead ofthis.test!.title(to get the title of current test)and I used
happy-domfor vitest test environment, because:nodeenvironment, and global injection was not possible.jsdomenvironment, there was a problem parsingUint8Arrayin protobuf becausejsdomoverrides some classes with its own implementation.(jsdom.Uint8Array) instanceof (v8.Uint8Array).Any background context you want to provide?
What are the relevant tickets?
Fixes #654
Checklist