Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Safe Navigation issue #217

Merged
merged 2 commits into from
Jun 26, 2021
Merged

Fix Safe Navigation issue #217

merged 2 commits into from
Jun 26, 2021

Conversation

mojosoeun
Copy link
Member

@mojosoeun mojosoeun commented Jun 25, 2021

What this PR does / why we need it?

Fix Safe Navigation issue

Change target from 'esnext' to 'es2019'

Any background context you want to provide?

kulshekhar/ts-jest#1283

kulshekhar/ts-jest#1283 (comment)

https://stackoverflow.com/questions/58725711/how-to-get-optional-chaining-working-in-typescript

Optional chaining was added in ES2020, which isn't supported by node yet. So if your 'target' compile option is ES2020 or ESNext, then typescript compiler will see an optional chaining operator and leave it alone. If your target is ES2019 or further back then typescript will transpile the feature into something that ndoe will understand .

What are the relevant tickets?

Fixes #197

Checklist

  • Added relevant tests or not required
  • Didn't break anything

Change from 'esnext' to 'es2019'
@mojosoeun mojosoeun requested a review from a team June 25, 2021 14:36
@codecov
Copy link

codecov bot commented Jun 25, 2021

Codecov Report

Merging #217 (e0cba87) into main (4c9e016) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #217   +/-   ##
=======================================
  Coverage   79.68%   79.68%           
=======================================
  Files          49       49           
  Lines        2820     2820           
  Branches      469      469           
=======================================
  Hits         2247     2247           
  Misses        404      404           
  Partials      169      169           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c9e016...e0cba87. Read the comment docs.

Copy link
Member

@ppeeou ppeeou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@dc7303 dc7303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dc7303 dc7303 unassigned ppeeou and dc7303 Jun 26, 2021
@hackerwins hackerwins merged commit 7e3a399 into main Jun 26, 2021
@hackerwins hackerwins deleted the soeunlee/197/save_navigation branch June 26, 2021 07:51
parkeunae pushed a commit to parkeunae/yorkie-js-sdk that referenced this pull request Jul 23, 2022
Change from 'esnext' to 'es2019'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Currently we are not able to use Safe Navigation
4 participants