Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove previously inserted elements in heap when running GC #216

Merged
merged 2 commits into from
Jun 25, 2021

Conversation

hackerwins
Copy link
Member

@hackerwins hackerwins commented Jun 21, 2021

What this PR does / why we need it?

Remove previously inserted elements in heap when running GC.

Any background context you want to provide?

What are the relevant tickets?

Fixes #214

Checklist

  • Added relevant tests or not required
  • Didn't break anything

@codecov
Copy link

codecov bot commented Jun 21, 2021

Codecov Report

Merging #216 (1b60426) into main (b7caae4) will increase coverage by 0.02%.
The diff coverage is 79.06%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #216      +/-   ##
==========================================
+ Coverage   79.65%   79.68%   +0.02%     
==========================================
  Files          49       49              
  Lines        2797     2820      +23     
  Branches      465      469       +4     
==========================================
+ Hits         2228     2247      +19     
- Misses        401      404       +3     
- Partials      168      169       +1     
Impacted Files Coverage Δ
src/document/json/rht_pq_map.ts 67.27% <66.66%> (-2.30%) ⬇️
src/document/proxy/object_proxy.ts 75.28% <66.66%> (-0.86%) ⬇️
src/api/converter.ts 81.81% <88.23%> (+0.24%) ⬆️
src/document/json/element.ts 88.23% <100.00%> (+14.90%) ⬆️
src/document/json/object.ts 82.00% <100.00%> (ø)
src/document/json/rga_tree_list.ts 85.60% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7caae4...1b60426. Read the comment docs.

@hackerwins hackerwins requested a review from a team June 21, 2021 06:07
@hackerwins hackerwins force-pushed the fix-rhtqpmap-purge-bug branch from f85159f to 0d72999 Compare June 25, 2021 09:13
@hackerwins hackerwins assigned mojosoeun, ppeeou and dc7303 and unassigned hackerwins Jun 25, 2021
@hackerwins hackerwins force-pushed the fix-rhtqpmap-purge-bug branch from 0d72999 to 1b60426 Compare June 25, 2021 13:54
@hackerwins hackerwins merged commit 4c9e016 into main Jun 25, 2021
@hackerwins hackerwins deleted the fix-rhtqpmap-purge-bug branch June 25, 2021 14:00
parkeunae pushed a commit to parkeunae/yorkie-js-sdk that referenced this pull request Jul 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug with rht_pq_map purge
4 participants