Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle concurrent editing and styling in Tree #178

Merged
merged 4 commits into from
May 14, 2024
Merged

Handle concurrent editing and styling in Tree #178

merged 4 commits into from
May 14, 2024

Conversation

7hong13
Copy link
Contributor

@7hong13 7hong13 commented May 13, 2024

What this PR does / why we need it?

Any background context you want to provide?

What are the relevant tickets?

Fixes #

Checklist

  • Added relevant tests or not required
  • Didn't break anything

@7hong13 7hong13 added the bug 🐞 Something isn't working label May 13, 2024
@7hong13 7hong13 added this to the 0.4.19 milestone May 13, 2024
@7hong13 7hong13 requested review from hackerwins and skhugh May 13, 2024 12:04
@7hong13 7hong13 self-assigned this May 13, 2024
skhugh
skhugh reviewed May 14, 2024
View reviewed changes
yorkie/src/androidTest/kotlin/dev/yorkie/document/json/JsonTreeTest.kt Outdated
import dev.yorkie.gson
import junit.framework.TestCase.assertTrue
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using kotlin test version of assertTrue seems more consistent :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done in 3fbd38c

@7hong13 7hong13 merged commit 5631a8e into main May 14, 2024
4 of 6 checks passed
@7hong13 7hong13 deleted the fix_tree_style branch May 14, 2024 04:24
@7hong13 7hong13 mentioned this pull request May 14, 2024
Closed
2 tasks
@hackerwins hackerwins mentioned this pull request Jun 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skhugh skhugh skhugh approved these changes

@hackerwins hackerwins Awaiting requested review from hackerwins

Assignees

@7hong13 7hong13

Labels
bug 🐞 Something isn't working
Projects
None yet
Milestone
0.4.19
Development

Successfully merging this pull request may close these issues.
2 participants
@7hong13 @skhugh