-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change NODE_ENV
value to 'development' temporarily for enabling Devtools
#214
Conversation
WalkthroughThe latest update to the project involves modifying the Changes
Sequence Diagram(s)No sequence diagrams are needed for this specific change. Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- frontend/.env.production (1 hunks)
Additional context used
Gitleaks
frontend/.env.production
4-4: Detected a Generic API Key, potentially exposing access to various services and sensitive operations. (generic-api-key)
Additional comments not posted (1)
frontend/.env.production (1)
1-1
: Ensure temporary changes are safe for deployment.Setting
NODE_ENV
to 'development' is necessary for enabling Devtools as mentioned. However, ensure there are safeguards or reminders to switch it back to 'production' to avoid potential security risks or performance issues in a live environment.
@@ -1,3 +1,4 @@ | |||
NODE_ENV=development | |||
VITE_API_ADDR="https://codepair-api.yorkie.dev" | |||
VITE_YORKIE_API_ADDR="https://api.yorkie.dev" | |||
VITE_YORKIE_API_KEY="cbovg64qfu96agb5i0fg" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove exposed API key.
The API key found in the environment file could lead to unauthorized access if exposed in a public repository. Consider using environment variables managed by a secure service or encrypting sensitive information.
- VITE_YORKIE_API_KEY="cbovg64qfu96agb5i0fg"
+ VITE_YORKIE_API_KEY=${{ secrets.YORKIE_API_KEY }}
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
VITE_YORKIE_API_KEY="cbovg64qfu96agb5i0fg" | |
VITE_YORKIE_API_KEY=${{ secrets.YORKIE_API_KEY }} |
Tools
Gitleaks
4-4: Detected a Generic API Key, potentially exposing access to various services and sensitive operations. (generic-api-key)
What this PR does / why we need it:
This PR temporarily changes the value of
NODE_ENV
from 'production' to 'development' to enable the Devtools for debugging purposes.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
In order to activate Devtools and facilitate debugging, it is necessary to set the environment to 'development' temporarily. This adjustment allows for better visibility and control during the debugging process.
Does this PR introduce a user-facing change?:
Additional documentation:
Checklist:
Summary by CodeRabbit