Fix Document Count Display Issue and Loading Progress Bar Size in Pagination #212
Conversation
WalkthroughThe changes enhance the functionality and presentation of the workspace documents list, both in the backend and frontend. A new Changes
Sequence Diagram(s)sequenceDiagram
participant Frontend
participant Backend
participant Database
Frontend->>Backend: Request documents (with pagination)
Backend->>Database: Fetch documents and count total documents
Database-->>Backend: Return documents list and total documents count
Backend-->>Frontend: Return documents and total count
Frontend-->>Frontend: Update UI to show all documents and correct total count
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (5)
- backend/src/workspace-documents/types/find-workspace-documents-response.type.ts (1 hunks)
- backend/src/workspace-documents/workspace-documents.service.ts (2 hunks)
- frontend/src/components/layouts/WorkspaceLayout.tsx (1 hunks)
- frontend/src/hooks/api/types/workspaceDocument.d.ts (1 hunks)
- frontend/src/pages/workspace/Index.tsx (3 hunks)
Additional comments not posted (8)
frontend/src/hooks/api/types/workspaceDocument.d.ts (1)
5-5: Addition oftotalLengthproperty is approved.This change aligns with the PR objectives to correctly display the total document count as pages are loaded.
backend/src/workspace-documents/types/find-workspace-documents-response.type.ts (1)
14-15: Addition oftotalLengthproperty is approved.Adding the
totalLengthproperty to the response type is crucial for front-end functionalities that rely on total document counts, which is a key fix in this PR.frontend/src/components/layouts/WorkspaceLayout.tsx (1)
15-17: Styling adjustments are approved.Changing from uniform padding to individual side padding allows for more flexible UI design and is consistent with the PR's aim to adjust UI elements like the progress bar size.
frontend/src/pages/workspace/Index.tsx (3)
50-50: Correct update of document count display.This change ensures that the total document count reflects all loaded pages, addressing a specific issue reported in the linked issue.
63-63: Adjustment to the stack element's maximum height is approved.Reducing the maximum height supports better UI layout and interaction, especially with the modified progress bar size.
72-73: Size adjustment of the loading progress bar is approved.Reducing the size of the progress bar as per PR objectives helps in maintaining a more proportionate UI design.
backend/src/workspace-documents/workspace-documents.service.ts (2)
64-69: Correct implementation of document count logic.The addition of counting documents based on
workspaceIdis crucial for accurate pagination and display, aligning perfectly with the PR objectives.
99-99: Proper inclusion oftotalLengthin response.Returning
totalLengthin the service response is essential for the frontend to display accurate document counts, fulfilling a key PR objective.
What this PR does / why we need it:
This PR addresses several issues mentioned in issue 211 regarding the document count display and loading progress bar in pagination:
Which issue(s) this PR fixes:
Fixes #211
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation:
Checklist:
Summary by CodeRabbit
New Features
Style