Use SwiftCLI #29
Merged
Use SwiftCLI #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yonaskolb
reviewed
May 30, 2018
| _ = try capture("swift", arguments: ["package", "generate-xcodeproj"], directory: packagePath.string) | ||
| } catch let error as CaptureError { | ||
| stdout <<< error.captured.rawStdout | ||
| stdout <<< error.captured.rawStderr |
| _ = try capture("swift", arguments: ["build", "--disable-sandbox"], directory: packagePath.string) | ||
| } catch let error as CaptureError { | ||
| stdout <<< error.captured.rawStdout | ||
| stdout <<< error.captured.rawStderr |
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a possible fix to #28. In most places I tried to make the fewest changes possible so that this PR wasn't too unwieldy. Most changes are relatively straight forward, but
FunctionParser.getParamsneeded to be largely rewritten.Bugs fixed:
beak runnilis now a valid value for optional function parametersPublic API changed:
public func execute(arguments: [String]) throws->public func execute(arguments: [String]? = nil) -> Int32I'd also to like to re-emphasize that I am not trying to force
SwiftCLIon this project in any way, this is just one solution to #28. If you decide to not useSwiftCLII'd be happy to open a new PR which fixes the SIGINT problem withSwiftShell!