Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: system prompt supports backend Overwrite and Prefix #917

Merged
merged 9 commits into from
Oct 16, 2024
Merged

feat: system prompt supports backend Overwrite and Prefix #917

merged 9 commits into from
Oct 16, 2024

Conversation

woorui
Copy link
Collaborator

@woorui woorui commented Oct 10, 2024

No description provided.

@woorui woorui self-assigned this Oct 10, 2024
@vercel Vercel
Copy link

vercel bot commented Oct 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
yomo ⬜️ Ignored (Inspect) Visit Preview Oct 16, 2024 6:34am

@codecov Codecov
Copy link

codecov bot commented Oct 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 86.36364% with 6 lines in your changes missing coverage. Please review.

Project coverage is 79.91%. Comparing base (4684c64) to head (3a55c3f).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/bridge/ai/api_server.go 25.00% 6 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #917      +/-   ##
==========================================
+ Coverage   79.80%   79.91%   +0.10%     
==========================================
  Files          50       50              
  Lines        2937     2958      +21     
==========================================
+ Hits         2344     2364      +20     
- Misses        421      423       +2     
+ Partials      172      171       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

venjiang
venjiang requested changes Oct 12, 2024
View reviewed changes
pkg/bridge/ai/caller.go Outdated Show resolved Hide resolved
@woorui woorui requested a review from venjiang October 12, 2024 05:14
@fanweixiao fanweixiao changed the title feat: caller supports setting system prompt and its opration feat: system prompt supports backend Overwrite and Prefix Oct 16, 2024
@fanweixiao fanweixiao added the feat Features which undefined clearly label Oct 16, 2024
@fanweixiao
Copy link
Member

🥇

@woorui woorui merged commit bb8e3db into master Oct 16, 2024
7 checks passed
@woorui woorui deleted the feat/prompt-op branch October 16, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@venjiang venjiang venjiang approved these changes

@fanweixiao fanweixiao Awaiting requested review from fanweixiao

Assignees

@woorui woorui

Labels
feat Features which undefined clearly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@woorui @fanweixiao @venjiang