-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: metadata in map[string]string #571
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Codecov Report
@@ Coverage Diff @@
## master #571 +/- ##
==========================================
+ Coverage 65.05% 66.35% +1.29%
==========================================
Files 40 39 -1
Lines 2767 2749 -18
==========================================
+ Hits 1800 1824 +24
+ Misses 840 800 -40
+ Partials 127 125 -2
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Summary
Simplifying
DataFrame
struct, new features implementation will be easier.Intended Outcome
Before, Metadata was encoded by y3 codec, it's a streaming codec used for reduce CPU workload in high load. But developers confused a lot when adding news features. After refactor Metadata to MsgPack, reduce the complexity.
How will it work?
Using
map[string]string
to store metadata as key-value pairs, and UsingmsgPack
to encode and decode it for transmitting. The current definition of the DataFrame struct is as follows: