Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance: あいまい検索無効時にワイルドカードを利用可能に #564

Merged
merged 8 commits into from
Jan 10, 2025
Merged

Enhance: あいまい検索無効時にワイルドカードを利用可能に #564

merged 8 commits into from
Jan 10, 2025

Conversation

penginn-net
Copy link
Collaborator

What

タイトル通り

Why

あいまい検索を無効にするとタグもしくは本文の完全一致になってしまうため

Additional info (optional)

Checklist

  • コントリビューションガイドを読みました( Read the contribution guide)
  • ローカル環境で動作しました(Test working in a local environment)
  • (必要なら)CHANGELOG_YOJO.mdの更新((If needed) Update CHANGELOG_YOJO.md)
  • (必要なら)テストの追加((If possible) Add tests)

@penginn-net
Enhance: あいまい検索無効時にワイルドカード検索を許可するように
15c572c 
あいまい検索を無効にすると完全一致クエリになるため
@penginn-net penginn-net added this to the yojo1.2.0 milestone Dec 7, 2024
@penginn-net penginn-net self-assigned this Dec 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 7, 2024 •
edited
Loading

이 PR에 의한 api.json 차이
차이점이 없습니다.
Get diff files from Workflow Page

@codecov Codecov
Copy link

codecov bot commented Dec 7, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 4.54545% with 21 lines in your changes missing coverage. Please review.

Project coverage is 59.90%. Comparing base (8350c4d) to head (8540e29).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
packages/backend/src/core/AdvancedSearchService.ts 4.54% 21 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##           develop     #564       +/-   ##
============================================
+ Coverage    19.85%   59.90%   +40.04%     
============================================
  Files          797      895       +98     
  Lines       123278   106667    -16611     
  Branches      1041     2831     +1790     
============================================
+ Hits         24483    63897    +39414     
+ Misses       98190    42750    -55440     
+ Partials       605       20      -585

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kozakura913
Copy link
Collaborator

関係無さそうな所でテスト落ちてるのなんだこれ

@kozakura913
Copy link
Collaborator

マージ遅れてるから次に回す

@kozakura913 kozakura913 modified the milestones: yojo1.2.0, yojo1.3.0 Dec 13, 2024
@penginn-net penginn-net changed the title Enhance: あいまい検索無効時にワイルドカード検索を許可するように Enhance: あいまい検索無効時にワイルドカードを利用可能に Jan 10, 2025
@penginn-net penginn-net merged commit 14141fe into yojo-art:develop Jan 10, 2025
31 of 33 checks passed
@penginn-net penginn-net deleted the advsearchWiledcard branch January 10, 2025 12:00
@kozakura913 kozakura913 mentioned this pull request Jan 27, 2025
Merged
kozakura913 added a commit to kozakura913/yojo-art that referenced this pull request Feb 11, 2025
@kozakura913
Merge pull request yojo-art#564
7cfe915 
* moderatorInactivityLimitDaysの型修正

* 翻訳機能テストのエラーコードを実態に合わせる

* WWW-Authenticateのテスト、Misskey->CherryPick

* ファイル付きTLテスト：タイムアウト時間を延長

* fix:非アクティブな通報通知はWebhook送信から除外される

* 絵文字をシステムユーザーとして再アップロードする機能の修正

* 使用されなくなった型定義の削除

* 存在しない変数を参照している問題の修正

* 到達不能コードの削除

* APNG画像のテスト修正

* 型の変更

* unitテスト修正
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kozakura913 kozakura913 kozakura913 approved these changes

Assignees

@penginn-net penginn-net

Labels
packages/backend
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@penginn-net @kozakura913