Feat: searchableByの対応 #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
packages/backend
packages/frontend
packages/cherrypick-js
labels
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #519 +/- ##
============================================
- Coverage 60.02% 40.45% -19.57%
============================================
Files 882 1676 +794
Lines 102419 227331 +124912
Branches 2697 2730 +33
============================================
+ Hits 61472 91967 +30495
- Misses 40890 134753 +93863
- Partials 57 611 +554 ☔ View full report in Codecov by Sentry. |
|
이 PR에 의한 api.json 차이 차이점은 여기에서 볼 수 있음--- base
+++ head
@@ -50055,6 +50055,15 @@
"isIndexable": {
"type": "boolean"
},
+ "searchableBy": {
+ "type": "string",
+ "enum": [
+ "public",
+ "followersAndReacted",
+ "reactedOnly",
+ "private"
+ ]
+ },
"hideOnlineStatus": {
"type": "boolean"
},
@@ -57297,6 +57306,19 @@
],
"default": null
},
+ "searchableBy": {
+ "type": [
+ "string",
+ "null"
+ ],
+ "enum": [
+ "public",
+ "followersAndReacted",
+ "reactedOnly",
+ "private"
+ ],
+ "default": "public"
+ },
"disableRightClick": {
"type": "boolean",
"default": false
@@ -57798,6 +57820,19 @@
],
"default": null
},
+ "searchableBy": {
+ "type": [
+ "string",
+ "null"
+ ],
+ "enum": [
+ "public",
+ "followersAndReacted",
+ "reactedOnly",
+ "private"
+ ],
+ "default": "public"
+ },
"disableRightClick": {
"type": "boolean",
"default": false |
penginn-net
force-pushed
the
searchable-by
branch
from
ba4870a to
b1f33ea
Compare
|
🏳 |
|
デフォ値がpublicだからindexableは落ちるに決まってましたわ |
kozakura913
requested changes
Nov 3, 2024
| @@ -954,6 +986,9 @@ export class AdvancedSearchService { | |||
| minimum_should_match: 1, | |||
| }, | |||
| }); | |||
| osFilter.bool.must_not.push({ term: { searchableBy: 'followersAndReacted' } }); | |||
There was a problem hiding this comment.
publicを許可にすると対応前に作成された投稿すべてが出てこなくなるのはどうなのという気持ち
| @@ -188,22 +188,26 @@ export class QueryService { | |||
| } | |||
|
|
|||
| @bindThis | |||
| public generateVisibilityQuery(q: SelectQueryBuilder<any>, me?: { id: MiUser['id'] } | null, followingFilter?: string): void { | |||
| public generateVisibilityQuery(q: SelectQueryBuilder<any>, me?: { id: MiUser['id'] } | null, search?: boolean, followingFilter?: string): void { | |||
There was a problem hiding this comment.
この位置にオプション追加すると意図しない影響出そう
packages/backend/src/core/activitypub/models/ApOutboxFetchService.ts
Outdated
Show resolved
Hide resolved
packages/backend/src/core/activitypub/models/ApPersonService.ts
Outdated
Show resolved
Hide resolved
packages/backend/src/core/activitypub/models/ApPersonService.ts
Outdated
Show resolved
Hide resolved
| }); | ||
|
|
||
| //色々出てくる | ||
| test('searchableBy(user: null, indexable false)', async () => { |
There was a problem hiding this comment.
一応publicでリアクションするケースもカバーしときたい
penginn-net
force-pushed
the
searchable-by
branch
from
0b98a1d to
3df00ab
Compare
penginn-net
force-pushed
the
searchable-by
branch
from
55e9647 to
1ac015d
Compare
kozakura913
approved these changes
Nov 4, 2024
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
searchableByの対応
Why
Resolve #440
Additional info (optional)
searchable_by_nobodyにも対応
Checklist