Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance: api/emojihostを指定できるように #514

Merged
merged 4 commits into from
Oct 20, 2024

Conversation

penginn-net
Copy link
Collaborator

@penginn-net penginn-net commented Oct 19, 2024

What

api/emojihostを指定できるように

Why

#486

Additional info (optional)

Checklist

  • コントリビューションガイドを読みました( Read the contribution guide)
  • ローカル環境で動作しました(Test working in a local environment)
  • (必要なら)CHANGELOG_YOJO.mdの更新((If needed) Update CHANGELOG_YOJO.md)
  • (必要なら)テストの追加((If possible) Add tests)

Copy link
Contributor

github-actions bot commented Oct 19, 2024

이 PR에 의한 api.json 차이

차이점은 여기에서 볼 수 있음
--- base
+++ head
@@ -54811,6 +54811,13 @@
                 "properties": {
                   "name": {
                     "type": "string"
+                  },
+                  "host": {
+                    "type": [
+                      "string",
+                      "null"
+                    ],
+                    "default": null
                   }
                 },
                 "required": [
@@ -54959,6 +54966,13 @@
                 "properties": {
                   "name": {
                     "type": "string"
+                  },
+                  "host": {
+                    "type": [
+                      "string",
+                      "null"
+                    ],
+                    "default": null
                   }
                 },
                 "required": [

Get diff files from Workflow Page

Copy link
Contributor

Thank you for sending us a great Pull Request! 👍
Please regenerate cherrypick-js type definitions! 🙏

example:

pnpm run build-cherrypick-js-with-types

Copy link

codecov bot commented Oct 19, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 40.49%. Comparing base (7fc7d17) to head (dc5887c).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
packages/backend/src/server/api/endpoints/emoji.ts 83.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #514       +/-   ##
============================================
+ Coverage    20.06%   40.49%   +20.43%     
============================================
  Files          789     1675      +886     
  Lines       117792   226622   +108830     
  Branches      1091     3786     +2695     
============================================
+ Hits         23638    91777    +68139     
- Misses       93563   134235    +40672     
- Partials       591      610       +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants