Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

通知APIがページ境界で重複する問題の修正 #509

Merged
merged 6 commits into from
Oct 18, 2024

Conversation

kozakura913
Copy link
Collaborator

@kozakura913 kozakura913 commented Oct 18, 2024

What

通知APIがページ境界で重複する問題の修正

Why

fix: #493

Additional info (optional)

Checklist

  • コントリビューションガイドを読みました( Read the contribution guide)
  • ローカル環境で動作しました(Test working in a local environment)
  • (必要なら)CHANGELOG_YOJO.mdの更新((If needed) Update CHANGELOG_YOJO.md)
  • (必要なら)テストの追加((If possible) Add tests)

@kozakura913 kozakura913 self-assigned this Oct 18, 2024
@kozakura913 kozakura913 added this to the yojo1.1.0 milestone Oct 18, 2024
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 38.61%. Comparing base (747f162) to head (38a9e2d).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
...rc/server/api/endpoints/i/notifications-grouped.ts 0.00% 1 Missing ⚠️
...ackend/src/server/api/endpoints/i/notifications.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #509      +/-   ##
===========================================
- Coverage    38.76%   38.61%   -0.16%     
===========================================
  Files         1671     1671              
  Lines       219995   220063      +68     
  Branches      3719     3708      -11     
===========================================
- Hits         85284    84980     -304     
- Misses      134065   134435     +370     
- Partials       646      648       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Oct 18, 2024

이 PR에 의한 api.json 차이

차이점은 여기에서 볼 수 있음

Get diff files from Workflow Page

@kozakura913 kozakura913 merged commit 10e333b into yojo-art:develop Oct 18, 2024
25 of 27 checks passed
@kozakura913 kozakura913 mentioned this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/api/i/notificationsの応答にuntilIdのノートが含まれる
2 participants