Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Opensearch利用時ファイルのセンシティブ状態が変更されたとき変更されるように #501

Merged
merged 5 commits into from
Oct 17, 2024

Conversation

penginn-net
Copy link
Collaborator

What

Opensearch利用時ファイルのセンシティブ状態が変更されたとき変更されるように

Why

非センシティブが見たいときにセンシティブが出てきたりするのは良くない

Additional info (optional)

Checklist

  • コントリビューションガイドを読みました( Read the contribution guide)
  • ローカル環境で動作しました(Test working in a local environment)
  • (必要なら)CHANGELOG_YOJO.mdの更新((If needed) Update CHANGELOG_YOJO.md)
  • (必要なら)テストの追加((If possible) Add tests)

@penginn-net penginn-net self-assigned this Oct 17, 2024
@penginn-net penginn-net added this to the yojo1.1.0 milestone Oct 17, 2024
@penginn-net penginn-net changed the title Enhance: Opensearch利用時ファイルのセンシティブ状態が変更されたとき変更されるように Fix: Opensearch利用時ファイルのセンシティブ状態が変更されたとき変更されるように Oct 17, 2024
Copy link
Contributor

github-actions bot commented Oct 17, 2024

이 PR에 의한 api.json 차이

차이점은 여기에서 볼 수 있음

Get diff files from Workflow Page

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 37.77778% with 28 lines in your changes missing coverage. Please review.

Project coverage is 38.76%. Comparing base (159a859) to head (6df3eca).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
packages/backend/src/core/AdvancedSearchService.ts 25.71% 26 Missing ⚠️
packages/backend/src/core/DriveService.ts 88.88% 1 Missing ⚠️
.../src/server/api/endpoints/notes/advanced-search.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #501   +/-   ##
========================================
  Coverage    38.76%   38.76%           
========================================
  Files         1671     1671           
  Lines       219920   219968   +48     
  Branches      2705     2705           
========================================
+ Hits         85250    85276   +26     
- Misses      134060   134082   +22     
  Partials       610      610           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@penginn-net penginn-net merged commit 2d9ccd3 into yojo-art:develop Oct 17, 2024
26 of 27 checks passed
@penginn-net penginn-net deleted the opensearch-sensitivefile branch October 17, 2024 12:57
@kozakura913 kozakura913 mentioned this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants