Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

連合割合%の表示が1000件以上のインスタンスでNaNになる不具合の修正 #462

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

kozakura913
Copy link
Collaborator

What

Number("1,000")===NaNの問題を修正する

Why

#437 で実装した表示が計算対象の数が1,000を超えてるとNaNになってしまう問題

Additional info (optional)

Checklist

  • コントリビューションガイドを読みました( Read the contribution guide)
  • ローカル環境で動作しました(Test working in a local environment)
  • (必要なら)CHANGELOG_YOJO.mdの更新((If needed) Update CHANGELOG_YOJO.md)
  • (必要なら)テストの追加((If possible) Add tests)

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 20.20%. Comparing base (de66bbf) to head (9fa335f).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
packages/frontend/src/scripts/use-chart-tooltip.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #462       +/-   ##
============================================
- Coverage    38.69%   20.20%   -18.50%     
============================================
  Files         1662      787      -875     
  Lines       217452   117200   -100252     
  Branches      2849     1088     -1761     
============================================
- Hits         84148    23679    -60469     
+ Misses      132695    92933    -39762     
+ Partials       609      588       -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kozakura913 kozakura913 self-assigned this Sep 18, 2024
@kozakura913 kozakura913 added this to the yojo1.1.0 milestone Sep 18, 2024
@kozakura913 kozakura913 merged commit 96492cc into yojo-art:develop Sep 19, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants