Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

about/federation.vueをreversiVersionでソート #436

Merged
merged 2 commits into from
Sep 14, 2024

Conversation

kozakura913
Copy link
Collaborator

@kozakura913 kozakura913 commented Sep 13, 2024

What

image

Why

resolve: #395

Additional info (optional)

Checklist

  • コントリビューションガイドを読みました( Read the contribution guide)
  • ローカル環境で動作しました(Test working in a local environment)
  • (必要なら)CHANGELOG_YOJO.mdの更新((If needed) Update CHANGELOG_YOJO.md)
  • (必要なら)テストの追加((If possible) Add tests)

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 40.44%. Comparing base (641c923) to head (c218eb7).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
...d/src/server/api/endpoints/federation/instances.ts 50.00% 2 Missing ⚠️
packages/frontend/src/pages/about.federation.vue 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #436       +/-   ##
============================================
+ Coverage    20.21%   40.44%   +20.23%     
============================================
  Files          787     1664      +877     
  Lines       117146   223652   +106506     
  Branches      1088     3816     +2728     
============================================
+ Hits         23676    90459    +66783     
- Misses       92882   132584    +39702     
- Partials       588      609       +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Sep 13, 2024

이 PR에 의한 api.json 차이

차이점은 여기에서 볼 수 있음
--- base
+++ head
@@ -34707,6 +34707,8 @@
                       "-firstRetrievedAt",
                       "+latestRequestReceivedAt",
                       "-latestRequestReceivedAt",
+                      "+reversiVersion",
+                      "-reversiVersion",
                       null
                     ]
                   }
@@ -34934,6 +34936,8 @@
                       "-firstRetrievedAt",
                       "+latestRequestReceivedAt",
                       "-latestRequestReceivedAt",
+                      "+reversiVersion",
+                      "-reversiVersion",
                       null
                     ]
                   }

Get diff files from Workflow Page

@kozakura913 kozakura913 merged commit 4ae086f into yojo-art:develop Sep 14, 2024
27 of 28 checks passed
@kozakura913 kozakura913 deleted the issue_395 branch September 14, 2024 05:26
@kozakura913 kozakura913 added this to the yojo1.1.0 milestone Sep 14, 2024
@kozakura913 kozakura913 mentioned this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

連合一覧のソートにリバーシを追加する
2 participants