Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: 翻訳に失敗したとき読み込み中のままになるのを修正 #407

Merged
merged 3 commits into from
Sep 4, 2024

Conversation

penginn-net
Copy link
Collaborator

@penginn-net penginn-net commented Sep 4, 2024

What

Fix: 翻訳に失敗したとき読み込み中のままになるのを修正

Why

Fix #397

Additional info (optional)

ロールで許可されていないなら翻訳ボタン表示しない方が良い気がする?

Checklist

  • コントリビューションガイドを読みました( Read the contribution guide)
  • ローカル環境で動作しました(Test working in a local environment)
  • (必要なら)CHANGELOG_YOJO.mdの更新((If needed) Update CHANGELOG_YOJO.md)
  • (必要なら)テストの追加((If possible) Add tests)

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 51.42857% with 17 lines in your changes missing coverage. Please review.

Project coverage is 38.70%. Comparing base (816925b) to head (57ac9a5).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...ackages/frontend/src/components/MkNoteDetailed.vue 0.00% 9 Missing ⚠️
packages/frontend/src/pages/user/home.vue 0.00% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #407       +/-   ##
============================================
+ Coverage    20.20%   38.70%   +18.49%     
============================================
  Files          786     1659      +873     
  Lines       117053   217140   +100087     
  Branches      1088     2798     +1710     
============================================
+ Hits         23651    84034    +60383     
- Misses       92814   132497    +39683     
- Partials       588      609       +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Sep 4, 2024

이 PR에 의한 api.json 차이

차이점은 여기에서 볼 수 있음
--- base
+++ head
@@ -62888,7 +62888,8 @@
                       "error": {
                         "message": "Translate of notes unavailable.",
                         "code": "UNAVAILABLE",
-                        "id": "50a70314-2d8a-431b-b433-efa5cc56444c"
+                        "id": "50a70314-2d8a-431b-b433-efa5cc56444c",
+                        "httpStatusCode": 403
                       }
                     }
                   },
@@ -79060,7 +79061,8 @@
                       "error": {
                         "message": "Translate of description unavailable.",
                         "code": "UNAVAILABLE",
-                        "id": "50a70314-2d8a-431b-b433-efa5cc56444c"
+                        "id": "50a70314-2d8a-431b-b433-efa5cc56444c",
+                        "httpStatusCode": 403
                       }
                     }
                   },

Get diff files from Workflow Page

@kozakura913 kozakura913 added this to the yojo1.0.0 milestone Sep 4, 2024
@penginn-net penginn-net merged commit a5562c7 into yojo-art:develop Sep 4, 2024
25 of 26 checks passed
@penginn-net penginn-net deleted the 397 branch September 4, 2024 10:52
@kozakura913 kozakura913 mentioned this pull request Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

翻訳エラーが表示されない
2 participants