Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

非ログインでリバーシの戦績が見れるように #404

Merged
merged 3 commits into from
Sep 4, 2024

Conversation

kozakura913
Copy link
Collaborator

What

非ログインユーザーが戦績を見れるようになる

Why

ローカルユーザーが参加してない対戦が見れないの不便

Additional info (optional)

fix: #403

Checklist

  • コントリビューションガイドを読みました( Read the contribution guide)
  • ローカル環境で動作しました(Test working in a local environment)
  • (必要なら)CHANGELOG_YOJO.mdの更新((If needed) Update CHANGELOG_YOJO.md)
  • (必要なら)テストの追加((If possible) Add tests)

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 20.20%. Comparing base (0aaa42f) to head (446c86b).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
packages/frontend/src/pages/reversi/game.board.vue 0.00% 6 Missing ⚠️
...ckages/frontend/src/pages/reversi/game.setting.vue 0.00% 2 Missing ⚠️
packages/frontend/src/pages/reversi/game.vue 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #404       +/-   ##
============================================
- Coverage    40.50%   20.20%   -20.30%     
============================================
  Files         1663      786      -877     
  Lines       223550   117046   -106504     
  Branches      2938     1088     -1850     
============================================
- Hits         90540    23651    -66889     
+ Misses      132401    92807    -39594     
+ Partials       609      588       -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kozakura913 kozakura913 merged commit 851ec1f into yojo-art:develop Sep 4, 2024
16 of 17 checks passed
@kozakura913 kozakura913 added this to the yojo1.0.0 milestone Sep 4, 2024
@kozakura913 kozakura913 deleted the guest_reversi_log branch September 4, 2024 09:57
@kozakura913 kozakura913 mentioned this pull request Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

非ログインでリバーシの戦績が見れない
2 participants