Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sw/create-notification警告抑制 #342

Merged
merged 1 commit into from
Aug 16, 2024
Merged

sw/create-notification警告抑制 #342

merged 1 commit into from
Aug 16, 2024

Conversation

kozakura913
Copy link
Collaborator

#111

Checklist

  • コントリビューションガイドを読みました( Read the contribution guide)
  • ローカル環境で動作しました(Test working in a local environment)
  • (必要なら)CHANGELOG_YOJO.mdの更新((If needed) Update CHANGELOG_YOJO.md)
  • (必要なら)テストの追加((If possible) Add tests)

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@kozakura913 kozakura913 marked this pull request as ready for review August 16, 2024 12:30
@penginn-net
Copy link
Collaborator

penginn-net commented Aug 16, 2024 •
edited
Loading

アップストリームのアップストリームに合わせるのはできなさそう？

https://github.com/misskey-dev/misskey/blob/6db3c50e32eb985ed76543e68ef0d75ffdad6874/packages/sw/src/scripts/create-notification.ts#L165-166

@kozakura913
Copy link
Collaborator Author

これが何なのかよくわかってないから困る

@penginn-net
Copy link
Collaborator

それなのよね

@penginn-net
Copy link
Collaborator

コミットログ見た感じ抑制で良さそう

@kozakura913 kozakura913 merged commit 5b8f6a0 into yojo-art:develop Aug 16, 2024
16 of 18 checks passed
@kozakura913 kozakura913 deleted the fix_ci_sw branch August 16, 2024 13:28
@kozakura913 kozakura913 added this to the yojo0.6.0 milestone Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@penginn-net penginn-net penginn-net approved these changes

Assignees
No one assigned
Labels
packages/sw
Projects
None yet
Milestone
yojo0.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@kozakura913 @penginn-net