Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

通知を削除する際に確認を出すように #287

Merged

Conversation

penginn-net
Copy link
Collaborator

@penginn-net penginn-net commented Aug 6, 2024

What

通知を削除する際に確認を出すように
既存の確認する関数を1ファイルに

Why

Resolve #286

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Update CHANGELOG_CHERRYPICK.md
  • (If possible) Add tests

@penginn-net penginn-net requested a review from kozakura913 August 6, 2024 16:41
@penginn-net penginn-net merged commit 5f99f19 into yojo-art:develop Aug 7, 2024
8 of 11 checks passed
@penginn-net penginn-net deleted the confirm-delete-notification branch August 7, 2024 17:12
Copy link

sonarqubecloud bot commented Aug 7, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
12.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@kozakura913 kozakura913 added this to the yojo0.5.0 milestone Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

通知削除のポップアップ
2 participants