Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

リバーシ連合 #271

Merged
merged 52 commits into from
Aug 4, 2024
Merged

Conversation

kozakura913
Copy link
Collaborator

@kozakura913 kozakura913 commented Aug 3, 2024

close: #256
配送するActivityの種類が追加される
配送するObjectの種類が追加される
UndoされるActivityの種類が追加される
ランダムマッチングは連合できない
招待を受ける時にその招待が無効であれば招待一覧を最新に更新する
配送遅延を考慮し、時間制限は適用しない

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Update CHANGELOG_CHERRYPICK.md
  • (If possible) Add tests

Copy link
Contributor

github-actions bot commented Aug 3, 2024

이 PR에 의한 api.json 차이

차이점은 여기에서 볼 수 있음
--- base
+++ head
@@ -80281,6 +80281,15 @@
                   "$ref": "#/components/schemas/Error"
                 },
                 "examples": {
+                  "NO_SUCH_USER": {
+                    "value": {
+                      "error": {
+                        "message": "No such user.",
+                        "code": "NO_SUCH_USER",
+                        "id": "0b4f0559-b484-4e31-9581-3f73cee89b28"
+                      }
+                    }
+                  },
                   "INVALID_PARAM": {
                     "value": {
                       "error": {
@@ -80583,6 +80592,10 @@
                   "multiple": {
                     "type": "boolean",
                     "default": false
+                  },
+                  "accept_only": {
+                    "type": "boolean",
+                    "default": false
                   }
                 }
               }

Get diff files from Workflow Page

Copy link

codecov bot commented Aug 3, 2024

Codecov Report

Attention: Patch coverage is 21.16904% with 499 lines in your changes missing coverage. Please review.

Project coverage is 64.23%. Comparing base (27bf432) to head (9515304).

Files Patch % Lines
packages/backend/src/core/ReversiService.ts 6.46% 188 Missing ⚠️
...ges/backend/src/core/activitypub/ApInboxService.ts 8.27% 122 Missing ⚠️
...ckend/src/core/activitypub/models/ApGameService.ts 35.66% 92 Missing ⚠️
.../backend/src/core/activitypub/ApRendererService.ts 9.57% 85 Missing ⚠️
...d/src/server/api/endpoints/reversi/cancel-match.ts 43.75% 8 Missing and 1 partial ⚠️
packages/backend/src/core/activitypub/type.ts 94.11% 2 Missing ⚠️
.../backend/src/server/api/endpoints/reversi/match.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #271      +/-   ##
===========================================
- Coverage    64.42%   64.23%   -0.19%     
===========================================
  Files         1072     1073       +1     
  Lines       132176   132763     +587     
  Branches      4681     5678     +997     
===========================================
+ Hits         85156    85282     +126     
+ Misses       46987    45660    -1327     
- Partials        33     1821    +1788     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarqubecloud bot commented Aug 3, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
15.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link
Collaborator

@jj1guj jj1guj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kozakura913 kozakura913 merged commit b70a0f5 into yojo-art:develop Aug 4, 2024
23 of 29 checks passed
@kozakura913 kozakura913 deleted the reversi_federation_1 branch August 4, 2024 02:23
@kozakura913 kozakura913 mentioned this pull request Aug 12, 2024
@kozakura913 kozakura913 added this to the yojo0.5.0 milestone Aug 14, 2024
catsmiry added a commit to catsmiry/misskey that referenced this pull request Jan 25, 2025
catsmiry added a commit to catsmiry/misskey that referenced this pull request Jan 25, 2025
catsmiry added a commit to catsmiry/misskey that referenced this pull request Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

リバーシを連合
4 participants