Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

絵文字インポート時に編集ダイアログを出す #243

Merged
merged 19 commits into from
Jul 28, 2024

Conversation

kozakura913
Copy link
Collaborator

@kozakura913 kozakura913 commented Jul 28, 2024

close:#242
デフォルト値リモートから取得した値で埋めた編集ダイアログをインポート直後に表示する
更新せずダイアログを閉じるとリモートの値を無視した従来通りの動作になる

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Update CHANGELOG_CHERRYPICK.md
  • (If possible) Add tests

Copy link

codecov bot commented Jul 28, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 24 lines in your changes missing coverage. Please review.

Project coverage is 78.07%. Comparing base (f4b7e2b) to head (507d5c2).

Files Patch % Lines
packages/frontend/src/scripts/import-emoji.ts 0.00% 24 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #243      +/-   ##
===========================================
- Coverage    78.14%   78.07%   -0.07%     
===========================================
  Files          194      195       +1     
  Lines        29054    29083      +29     
  Branches       474      474              
===========================================
+ Hits         22703    22708       +5     
- Misses        6345     6369      +24     
  Partials         6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kozakura913 kozakura913 self-assigned this Jul 28, 2024
@kozakura913 kozakura913 requested a review from penginn-net July 28, 2024 01:34
@penginn-net
Copy link
Collaborator

penginn-net commented Jul 28, 2024

cherrypickのノート上から絵文字インポートするときにもほしい

@kozakura913
Copy link
Collaborator Author

追加した

Copy link

sonarcloud bot commented Jul 28, 2024

@kozakura913 kozakura913 merged commit 03e5589 into yojo-art:develop Jul 28, 2024
13 of 18 checks passed
@kozakura913 kozakura913 deleted the enhance_emoji_import branch July 28, 2024 05:42
@kozakura913
Copy link
Collaborator Author

frontend/src/scripts/import-emoji.tsのSPDX忘れてるじゃん

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants