Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ローカルのみオプションを削除 #235

Merged
merged 2 commits into from
Jul 27, 2024

Conversation

kozakura913
Copy link
Collaborator

@kozakura913 kozakura913 commented Jul 27, 2024

DBに書き込む値をlocalOnly:falseに固定。フロントエンドも削除

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Update CHANGELOG_CHERRYPICK.md
  • (If possible) Add tests

Copy link

codecov bot commented Jul 27, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 64.44%. Comparing base (eb38b36) to head (8a92965).

Files Patch % Lines
...s/backend/src/server/api/endpoints/notes/create.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #235      +/-   ##
===========================================
+ Coverage    63.10%   64.44%   +1.33%     
===========================================
  Files         1067     1070       +3     
  Lines       127209   132072    +4863     
  Branches      4621     4679      +58     
===========================================
+ Hits         80277    85113    +4836     
- Misses       46899    46926      +27     
  Partials        33       33              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kozakura913 kozakura913 requested a review from penginn-net July 27, 2024 09:14
Copy link
Contributor

github-actions bot commented Jul 27, 2024

이 PR에 의한 api.json 차이

차이점은 여기에서 볼 수 있음
--- base
+++ head
@@ -56574,10 +56574,6 @@
                     "minLength": 1,
                     "maxLength": 100
                   },
-                  "localOnly": {
-                    "type": "boolean",
-                    "default": false
-                  },
                   "reactionAcceptance": {
                     "type": [
                       "string",

Get diff files from Workflow Page

Copy link

sonarcloud bot commented Jul 27, 2024

@kozakura913
Copy link
Collaborator Author

なんかチャンネルのヤツも巻き込んでるっぽいから外のフォークに取り込むなら注意

Copy link
Collaborator

@penginn-net penginn-net left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

良さそう

@kozakura913 kozakura913 merged commit 1dc0d25 into yojo-art:develop Jul 27, 2024
24 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants