Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix:グループの招待に返答すると通知が壊れる #204

Merged
merged 7 commits into from
Jul 20, 2024

Conversation

penginn-net
Copy link
Collaborator

@penginn-net penginn-net commented Jul 17, 2024

What

Fix #192
招待に返答すると招待情報がDBから消される
通知を読むときにRedisにある招待情報をもとにDBから探そうとしてエラーがでるから通知を消す

Why

Fix #192

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Update CHANGELOG_CHERRYPICK.md
  • (If possible) Add tests

@penginn-net penginn-net changed the title 通知全滅ではなくなった Fix:グループに招待に返答すると通知が壊れる Jul 17, 2024
@penginn-net penginn-net changed the title Fix:グループに招待に返答すると通知が壊れる Fix:グループの招待に返答すると通知が壊れる Jul 17, 2024
Copy link
Contributor

github-actions bot commented Jul 17, 2024

이 PR에 의한 api.json 차이

차이점은 여기에서 볼 수 있음

Get diff files from Workflow Page

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 12.50000% with 35 lines in your changes missing coverage. Please review.

Project coverage is 63.12%. Comparing base (e1c9e8d) to head (ec0328d).
Report is 3 commits behind head on develop.

Files Patch % Lines
packages/backend/src/core/NotificationService.ts 10.34% 26 Missing ⚠️
...r/api/endpoints/users/groups/invitations/accept.ts 16.66% 5 Missing ⚠️
...r/api/endpoints/users/groups/invitations/reject.ts 20.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #204      +/-   ##
===========================================
- Coverage    64.51%   63.12%   -1.39%     
===========================================
  Files         1068     1067       -1     
  Lines       131907   127200    -4707     
  Branches      5620     5606      -14     
===========================================
- Hits         85099    80298    -4801     
- Misses       44994    46869    +1875     
+ Partials      1814       33    -1781     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@penginn-net penginn-net reopened this Jul 19, 2024
@penginn-net penginn-net marked this pull request as ready for review July 19, 2024 05:18
@penginn-net penginn-net requested a review from kozakura913 July 19, 2024 05:43
@penginn-net penginn-net deleted the fix-notify branch July 20, 2024 00:17
@penginn-net
Copy link
Collaborator Author

なんかブランチ消えてる

@penginn-net penginn-net restored the fix-notify branch July 20, 2024 20:49
@penginn-net penginn-net reopened this Jul 20, 2024
@penginn-net penginn-net merged commit a362460 into yojo-art:develop Jul 20, 2024
11 of 18 checks passed
@penginn-net penginn-net deleted the fix-notify branch July 20, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

グループに招待されると通知が壊れる
2 participants