Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Their lights" #22095

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

"Their lights" #22095

wants to merge 19 commits into from

Conversation

AMyriad
Copy link
Contributor

@AMyriad AMyriad commented May 23, 2024

Document the changes in your pull request

Hello hi. This PR resprites all of our lights and light tubes and variants of those things. Bonus stuff includes:

  • Reorganizing icons/obj/lighting.dmi to better please your brains pattern recognition bits
  • Respriting the light replacer
  • Inhand sprites for holding light tubes
  • Updated some AI buttons concerning light tubes and cameras, since those were updated recently as well

A solid 90% of the work here is thanks to:
Paxilmaniac for initially respriting lights in tgstation/tgstation#77229
Onule for editing the lights to look much better in tgstation/tgstation#77594
RedBaronFlyer for adding inhands and editing light tube box overlays to match in tgstation/tgstation#79755
L0pz for respriting the light replacer tool in tgstation/tgstation#83546 so I could steal it in the friendliest way possible before they merge it themselves, tweak the sprite to look even nicer, and include it in this PR

Behold da lights

image
image
image
image

Why is this good for the game?

Simple answer? They look good.

Simpleish answer?
These are one of the few things from /TG/ I like a lot, they strike a good stylistic balance between simple and complicated., something we're in sore need of.

Testing

  • Make sure everything shows up properly
  • Resprite some fixture frame states
  • Make lighting overlays fully transparent

image

Spriting

Most sprites greatly modified by myself (like the overlays for example)

BEFORE
image

AFTER
image

Malf AI ability updates:
image --> image

image --> image
(repathed floor_emergency to avoid duplicate icons)

image --> image
this one I'm proud of since it's animated like this
reactivate_cameras

image image

Wiki Documentation

Ye I'll do that

Changelog

🆑 AMyriad, Paxilmaniac, Onule, RedBaronFlyer, L0pz
imageadd: Light bulbs, light tubes, floodlights, and light fixtures of all varieties have been visually overhauled
imageadd: Light tubes will now show up in your hands when held
imageadd: Resprited the light replacer tool
imageadd: Floor lights should now also turn purple if a revenant uses their shock ability
imageadd: Resprited malf AI's ability buttons for "blackout", "emergency lights", and "reactivate cameras"
/:cl:

@AMyriad AMyriad requested a review from a team as a code owner May 23, 2024 21:57
@Yogbot-13 Yogbot-13 added the Sprites This PR has spriting changes label May 23, 2024
@ThePissGuy
Copy link

can we make this the default sprite
image

@AMyriad AMyriad added the Awaiting - Action - Testing TEST YOUR STUFF label May 23, 2024
@ThePissGuy
Copy link

or show up when you clownmag

@Cartlord
Copy link
Contributor

good technical quality, i just think they look too complex compared to other stuff here - they stick out.

@AMyriad
Copy link
Contributor Author

AMyriad commented May 29, 2024

good technical quality, i just think they look too complex compared to other stuff here - they stick out.

They should match our newer wall mounts - like cameras - better than what we use now

@StupidTums
Copy link

good technical quality, i just think they look too complex compared to other stuff here - they stick out.

They should match our newer wall mounts - like cameras - better than what we use now

Sprites look good. Adds another incentive to get those walls re-sprited :^)

@AMyriad AMyriad added Awaiting - Action - Sprite Review Awaiting sprite review from sprite maintainers and removed Awaiting - Action - Testing TEST YOUR STUFF labels Jun 5, 2024
@cuackles cuackles marked this pull request as draft June 12, 2024 18:44
Copy link
Contributor

@cuackles cuackles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lights will be reviewed once the wall re sprites are more close to being completed

@Firewolf34
Copy link
Contributor

Very nice! The old wall lights have felt a bit broken honestly ever since that bug with the color happened a few years ago. I am glad to see they're getting a once-over. Great work! With lighting being more important now that departments have the option to start in a "lights out" state, a bit of polish is nice.

Yogbot-13 added a commit that referenced this pull request Nov 1, 2024
Yogbot-13 added a commit that referenced this pull request Nov 1, 2024
Yogbot-13 added a commit that referenced this pull request Nov 8, 2024
Yogbot-13 added a commit that referenced this pull request Nov 26, 2024
Yogbot-13 added a commit that referenced this pull request Nov 27, 2024
Yogbot-13 added a commit that referenced this pull request Dec 4, 2024
Yogbot-13 added a commit that referenced this pull request Dec 4, 2024
Yogbot-13 added a commit that referenced this pull request Dec 5, 2024
Yogbot-13 added a commit that referenced this pull request Dec 6, 2024
Yogbot-13 added a commit that referenced this pull request Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting - Action - Sprite Review Awaiting sprite review from sprite maintainers Purgatory pr limbo, Jamie look at this Sprites This PR has spriting changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants