Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Radiation Anomaly: Revengeance #20031

Merged
merged 10 commits into from
Aug 23, 2023
Merged

Radiation Anomaly: Revengeance #20031

merged 10 commits into from
Aug 23, 2023

Conversation

warface1234455
Copy link
Contributor

@warface1234455 warface1234455 commented Aug 11, 2023 •
edited
Loading

bring back rad anomaly for real

Document the changes in your pull request

readd radiation anomaly that shoots radballs and emits radiation (this is normal anomaly that doesnt spawn rad goat, admin one does)

replaces the orange goat with rad goat on goat search shuttle

rainbow goat is now replaced with rad goat in exotic goat crate

Spriting

rad

Wiki Documentation

document of changes

Changelog

🆑
rscadd: readd radiation anomaly that shoots radballs and emits radiation (this is normal anomaly that doesnt spawn rad goat, admin one does)
mapping: replaces the orange goat with rad goat on goat search shuttle
tweak: rainbow goat is now replaced with rad goat in exotic goat crate
/:cl:

@Yogbot-13 Yogbot-13 added the Feature This adds new content to the game label Aug 11, 2023
@warface1234455 warface1234455 marked this pull request as draft August 11, 2023 13:50
@warface1234455 warface1234455 marked this pull request as ready for review August 11, 2023 13:50
@warface1234455 warface1234455 marked this pull request as draft August 11, 2023 13:55
@github-actions github-actions bot added the Mapping Will result in a change to a map. label Aug 11, 2023
@warface1234455 warface1234455 marked this pull request as ready for review August 11, 2023 14:43
@warface1234455 warface1234455 requested a review from a team as a code owner August 11, 2023 14:43
@warface1234455
Copy link
Contributor Author

require test merge because my private server is no longer working

Ethan4303
Ethan4303 approved these changes Aug 19, 2023
View reviewed changes
Copy link
Contributor

@Ethan4303 Ethan4303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mappings good

SapphicOverload
SapphicOverload requested changes Aug 20, 2023
View reviewed changes
Copy link
Contributor

@SapphicOverload SapphicOverload left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably document the map changes, and that the exotic goat crate can have radioactive goats now. Otherwise mostly fine.

code/game/objects/structures/crates_lockers/crates.dm Show resolved Hide resolved
code/modules/spells/spell_types/conjure/rad_goat.dm Outdated Show resolved Hide resolved
SapphicOverload
SapphicOverload approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@SapphicOverload SapphicOverload left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, still waiting on balance council

@Moltijoe Moltijoe added Balance Council Approved This PR was approved by the Balance Council. and removed Awaiting - Action - Balance Review Code Director Review labels Aug 23, 2023
@Moltijoe Moltijoe merged commit c683c54 into yogstation13:master Aug 23, 2023
5 checks passed
@Yogbot-13 Yogbot-13 added DME Edit This PR affects the yogstation.DME file Tweak This PR contains changes to the game. labels Aug 23, 2023
Yogbot-13 added a commit that referenced this pull request Aug 23, 2023
@Yogbot-13
Automatic changelog generation #20031 [ci skip]
1b820c2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SapphicOverload SapphicOverload SapphicOverload approved these changes

@Ethan4303 Ethan4303 Ethan4303 approved these changes

Assignees

@SapphicOverload SapphicOverload

Labels
Balance Council Approved This PR was approved by the Balance Council. DME Edit This PR affects the yogstation.DME file Feature This adds new content to the game Mapping Will result in a change to a map. Tweak This PR contains changes to the game.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@warface1234455 @Ethan4303 @SapphicOverload @Yogbot-13 @Moltijoe