Refactor #22
Merged
Refactor #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- off() clears handlers and triggering after that, would call no handlers
yoannmoinet
added a commit
that referenced
this pull request
Nov 29, 2015
refactor: major refactor with big performances
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major refactor
API Changes
The API doesn't change much, only two additions on the manager.
ids: Array of all nipples' ids this manager has.id: Number identifying the manager. Is incremental.Semantic Changes
From this refactor we'll start a semantic switch.
I'll prepare another PR to apply this switch.
The
Manageras we know it today will become aCollection.There can be multiple instances of
Collections, and this is what is returned by thenipplejs.create()function.And we'll welcome the
Managerthat will handle all theCollections.It is the general factory and exists only as one instance, it can be found under
nipplejs.factory(for now).Tests
I was able to add tests (FINALLY) with Casper.
They don't test much for now, only multitouch effects.
But this is a really good starting point.
Closes #16 #20 and #14