Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is the best way to render a feature layer using drawingInfo in Webmap JSON? #34

Open
2 of 3 tasks
ynunokawa opened this issue Jun 20, 2016 · 3 comments
Open
2 of 3 tasks

Comments

@ynunokawa
Copy link
Owner

ynunokawa commented Jun 20, 2016

I think that feature layers to include a feature collection with drawingInfo should be rendered using Esri Leaflet Renderers in the issue #32 .
The goal of this concept is that all feature layers use the same logic as Esri Leaflet Renderers to render.

There are prospected requirements to perform it.

  • Esri Leaflet Renderers can refer original metadata with drawingInfo
  • It renders FeatureCollection using renderer modules of Esri Leaflet Renderers (for the present)
  • L.esri.FeatureLayer can refer a feature collection
@jgravois
Copy link
Contributor

just to clarify, it sounds like you are proposing:

  • that L.esri.featureLayer should accept either a GeoJSON feature collection or a url in its constructor?
  • esri-leaflet-renderers is able to interpret drawingInfo passed in the object constructor and skip fetching information about symbology from the service itself entirely?

is that correct?

@ynunokawa
Copy link
Owner Author

Yes, that's right.

@ynunokawa
Copy link
Owner Author

ynunokawa commented Jun 21, 2016

esri-leaflet-renderers is able to interpret drawingInfo passed in the object constructor and skip fetching information about symbology from the service itself entirely?

I have updated to rewrite drawingInfo from the service with original drawingInfo in esri-leaflet-renderers and created PR. :octocat:

It use new drawingInfo option of L.esri.FeatureLayer as the below.

L.esri.featureLayer({
  url: 'http://...',
  drawingInfo: webmapJson.***.drawingInfo
});

Please check it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants