Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make the unreal settings more readable #172

Conversation

moonyuet
Copy link
Member

Changelog Description

This PR is to make the unreal settings more readable
Resolve #149

Additional review information

Please build and install addon before testing

Testing notes:

  1. Launch Unreal
  2. Load and Publish(Load anything and publish render)

@moonyuet moonyuet self-assigned this Nov 29, 2024
@moonyuet moonyuet added the type: enhancement Improvement of existing functionality or minor addition label Nov 29, 2024
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect to me!

Nice job!

It helps a lot...separating those into categories of its own!
Screenshot 2024-11-29 135007

Screenshot 2024-11-29 135019

@iLLiCiTiT
Copy link
Member

Missing conversion of settings overrides.

@moonyuet moonyuet force-pushed the enhancement/AYON-Menu-_reorder-the-menu-items-to-more-following-the-workflow-logic branch from c06844d to 8088ba3 Compare November 29, 2024 16:31
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me...

Just one question regarding the Alembic Import Setting as there used to be maya and 3dsmax before but now it says custom beside the maya implicit one.

@moonyuet is that fine?
Screenshot 2024-12-02 100328

@moonyuet moonyuet requested a review from LiborBatek December 2, 2024 09:40
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now...

image

@moonyuet
Copy link
Member Author

moonyuet commented Dec 6, 2024

Should we merge this or there is something else we need to do to improve the settings to be more readable>

@LiborBatek
Copy link
Member

@moonyuet Im all in for merging!

@moonyuet moonyuet merged commit ec7e676 into develop Dec 8, 2024
1 check passed
@moonyuet moonyuet deleted the enhancement/AYON-Menu-_reorder-the-menu-items-to-more-following-the-workflow-logic branch December 8, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Organise UE addons settings for better readibility
3 participants