Fix bug where custom project code field wasn't being used on sync from Ayon to SG

[fabiaserra]

The custom project code field was missing on this call:

    # Append the project's direct children.
    for ay_project_child in entity_hub._entities_by_parent_id[entity_hub.project_name]:
        ay_entities_deck.append((
            get_sg_entity_as_ay_dict(sg_session, "Project", sg_project["id"], project_code_field),
            ay_project_child
        ))

Although perhaps better than querying the sg_project again the best would be to append the existing sg_project variable that already exists on the function and contains the project code field, something like:

    # Append the project's direct children.
    for ay_project_child in entity_hub._entities_by_parent_id[entity_hub.project_name]:
        ay_entities_deck.append((
           _sg_to_ay_dict(sg_project, project_code_field)
            ay_project_child
        ))

@Minkiu thoughts?

[Minkiu]

The custom project code field was missing on this call:

    # Append the project's direct children.
    for ay_project_child in entity_hub._entities_by_parent_id[entity_hub.project_name]:
        ay_entities_deck.append((
            get_sg_entity_as_ay_dict(sg_session, "Project", sg_project["id"], project_code_field),
            ay_project_child
        ))

Although perhaps better than querying the sg_project again the best would be to append the existing sg_project variable that already exists on the function and contains the project code field, something like:

    # Append the project's direct children.
    for ay_project_child in entity_hub._entities_by_parent_id[entity_hub.project_name]:
        ay_entities_deck.append((
           _sg_to_ay_dict(sg_project, project_code_field)
            ay_project_child
        ))

@Minkiu thoughts?

That would probably work, we'd need to change the function to remove the leading _ but I get your point; although get_sg_entity_as_ay_dict will add more fields to the query, while the of sg_project might not have everything required...

[fabiaserra]

That would probably work, we'd need to change the function to remove the leading _ but I get your point; although get_sg_entity_as_ay_dict will add more fields to the query, while the of sg_project might not have everything required...

Yeah I had the same thought, let's leave it like this then

[fabiaserra]

@Minkiu this was overriding the label every time

[Minkiu]

Here I though I was playing it safe... 🤦 thanks!

[Minkiu]

Thanks for the contribution, merging!

[Minkiu]

Might as well delete it from line 45 since we are not using it any more, and we trust that it comes with the payload...

[Minkiu]

Here I though I was playing it safe... 🤦 thanks!