Asset renaming synchronization #102
Merged
+204
−136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve error logging and handling in ShotgridListener. Refactor code to enhance readability and maintainability.
- Updated method parameters for event handling - Improved logging for event processing - Added validation for immutable entities
|
Task linked: AY-5537 Shotgrid: renaming assets |
Update package versions to 0.4.2-dev.4 for shotgrid addon, leecher, processor, and transmitter in respective pyproject.toml files.
Ensure Shotgrid API Key is set in the Addon System settings to avoid errors during processing. If key is missing, a ValueError will be raised with instructions on how to set it properly.
Base automatically changed from
bugfix/AY-5550_Failing-transmitter-synchronization-service
to
develop
May 31, 2024 11:44
- Refactored service tools to utilize a common `service_main` function for processor, leecher, and transmitter services. This simplifies code duplication and improves maintainability.
- Refactored the way service addon settings are retrieved during initialization to ensure correct assignment and usage.
Details: - Removed extra blank line. - Deleted a redundant comment.
Update version numbers in multiple files for shotgrid components to 0.4.2-dev.5 to reflect the latest changes and improvements.
MilaKudr
approved these changes
May 31, 2024
…-optimisation Services speed optimisation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an issue where assets renamed in SG weren't updating correctly. Now, if a folder entity hasn't published any product (is immutable), we'll rename it on the AYON side. If the folder entity is hierarchically immutable, we won't rename it and will skip the event.
This PR contain also code changes from #100