Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AY-7320 Skip meshes without faces in explicit face set member assignments #217

Conversation

BigRoy
Copy link
Contributor

@BigRoy BigRoy commented Jan 13, 2025

Changelog Description

  1. Skip meshes without faces in explicit face set member assignments
  2. Consider only doing the face assignment conversion on meshes actually in the export, instead of all that happen to be in the instance

Additional review information

  • Avoids a No object matches name error when trying to force face shader assignments for Write Face Sets if a mesh has no faces at all.
  • Also fixes the forced face set assignments to process all meshes in the instance, now it only includes e.g. meshes that are inside the out_SET for animation instances.

Testing notes:

  1. Export a mesh without faces (yeah, that'd still be a problem!) with Write Face Sets with this conversion enabled.
  2. It should not error on our code.

@BigRoy BigRoy added the type: bug Something isn't working label Jan 13, 2025
@BigRoy BigRoy requested a review from moonyuet January 13, 2025 17:08
@BigRoy BigRoy self-assigned this Jan 13, 2025
@BigRoy BigRoy added the sponsored This is directly sponsored by a client or community member label Jan 13, 2025
@BigRoy BigRoy requested a review from LiborBatek January 13, 2025 21:22
@BigRoy BigRoy changed the title Skip meshes without faces in explicit face set member assignments AY-7320 Skip meshes without faces in explicit face set member assignments Jan 13, 2025
@BigRoy BigRoy linked an issue Jan 13, 2025 that may be closed by this pull request
Copy link
Member

@moonyuet moonyuet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good for me. Did the test with published in maya and imported in unreal. The face sets for shader still kept in Unreal as expected.
image

@BigRoy BigRoy merged commit b3cd635 into ynput:develop Jan 14, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sponsored This is directly sponsored by a client or community member type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AY-7320_Maya Animation Publish errors on mesh without faces
2 participants