Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor stagingDir_custom -> stagingDir_is_custom #212

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Refactor stagingDir_custom -> stagingDir_is_custom #212

merged 2 commits into from
Jan 9, 2025

Conversation

BigRoy
Copy link
Contributor

@BigRoy BigRoy commented Jan 8, 2025

Changelog Description

Refactor stagingDir_custom -> stagingDir_is_custom to match ynput/ayon-core#1069

Additional review information

Test with ynput/ayon-core#1069

Testing notes:

  1. Custom staging dir should work for rendering validations

@BigRoy BigRoy added the type: enhancement Improvement of existing functionality or minor addition label Jan 8, 2025
@BigRoy BigRoy requested a review from LiborBatek January 8, 2025 12:30
@BigRoy BigRoy self-assigned this Jan 8, 2025
@BigRoy BigRoy mentioned this pull request Jan 8, 2025
Merged
LiborBatek
LiborBatek reviewed Jan 8, 2025
View reviewed changes
Copy link
Member

@LiborBatek LiborBatek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My Ayon launcher immedeatelly crashes with this in the console: been fixed meanwhile

image

@LiborBatek LiborBatek self-requested a review January 8, 2025 14:52
LiborBatek
LiborBatek approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested both with and without custom staging dir enabled and all is working without issues.

Validations and Repair actions works when using custom staging directory too...

Screenshot 2025-01-08 154605
and once hitting Repair btn:

Screenshot 2025-01-08 154733

And my renders finnishes on farm without errors...

@BigRoy BigRoy merged commit a4b7d35 into ynput:develop Jan 9, 2025
1 check passed
@iLLiCiTiT iLLiCiTiT changed the title Refactor stagingDir_custom -> stagingDir_is_custom Refactor stagingDir_custom -> stagingDir_is_custom Jan 14, 2025
@iLLiCiTiT iLLiCiTiT changed the title Refactor stagingDir_custom -> stagingDir_is_custom Refactor stagingDir_custom -> stagingDir_is_custom Jan 14, 2025
@kalisp kalisp mentioned this pull request Jan 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LiborBatek LiborBatek LiborBatek approved these changes

Assignees

@BigRoy BigRoy

Labels
type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BigRoy @LiborBatek