Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Platform name is not passed to 'download_dependency_package' #77

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Platform name is not passed to 'download_dependency_package' #77

merged 1 commit into from
Jan 3, 2024

Conversation

iLLiCiTiT
Copy link
Member

Changelog Description

Platform name is not used in download_dependency_package since ayon-python-api 0.3.x, and since last release is marked as deprecated.

Testing notes:

  1. Make sure bundle you're going to use have set dependency package.
  2. Remove the dependency package from %LOCALAPPDATA%/Ynput/AYON/dependency_packages/ if you have it downloaded already.
  3. Run ayon-launcher with this PR (from code or build)
  4. Download of dependency package should start.
  5. It should download it just fine.

@iLLiCiTiT iLLiCiTiT requested a review from kalisp December 28, 2023 13:44
@kalisp kalisp assigned iLLiCiTiT and unassigned kalisp Jan 3, 2024
@iLLiCiTiT iLLiCiTiT merged commit f07827a into develop Jan 3, 2024
@iLLiCiTiT iLLiCiTiT deleted the enhancement/dont-pass-platform-name branch January 3, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalisp kalisp kalisp approved these changes

Assignees

@iLLiCiTiT iLLiCiTiT

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iLLiCiTiT @kalisp