Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker build: CentOS build fixes #49

Merged
merged 5 commits into from
Aug 31, 2023

Conversation

iLLiCiTiT
Copy link
Member

Changelog Description

Fixed copy of output from CentOS. Force poetry to lower urllib3 version if OpenSSL version is lower than 1.1.1.

Define urllib3 version that supports older OpenSSL in pyproject.toml. That is because most of DCCs are build with older ssl (e.g. Maya 2022, Nuke 13).

Testing notes:

  1. Run ./tools/make.sh docker-build centos7 (or ./tools/manage.ps1 docker-build centos7 for windows)
  2. Check output

@Minkiu
Copy link
Contributor

Minkiu commented Aug 30, 2023

I'm working on this same file ((Dockerfile.centos7) for the AppImage packaging and I'm refactoring it (appimages should be build in the oldest possible distro, hence this)a bit, so I'd say we close this and open the other one, there's no need to downgrade urllib while using newer openssl11; the other PR is not yet done, but can open as Draft.

EDIT: wait, if we build with a newer urllib, does it fail in the DCC?

@iLLiCiTiT
Copy link
Member Author

iLLiCiTiT commented Aug 30, 2023

there's no need to downgrade urllib while using newer openssl11

We must because of DCCs.

wait, if we build with a newer urllib, does it fail in the DCC?

Yes

@iLLiCiTiT
Copy link
Member Author

iLLiCiTiT commented Aug 30, 2023

Do you have more changes in the branch? If yes what are you doing actually, I don't see any task assigned to you regarding ayon launcher?

This is must have fix, if it will take you more than 2 days we should merge this and then you should continue rom here.

@Minkiu
Copy link
Contributor

Minkiu commented Aug 31, 2023

Hey, sure, lets merge it with your changes, I'm using the centos7 docker file as base to do the AppImage bundle

@iLLiCiTiT iLLiCiTiT merged commit 47e427f into develop Aug 31, 2023
@iLLiCiTiT iLLiCiTiT deleted the enhancement/lower-urllib3-version branch August 31, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants