Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows auto-update: Ask for admin permissions when required #39

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Windows auto-update: Ask for admin permissions when required #39

merged 1 commit into from
Aug 21, 2023

Conversation

iLLiCiTiT
Copy link
Member

Changelog Description

Installer auto-update mechanism asks for permissions if target directory requires it. The auto-update crashes if process is executed in headless mode. If the process is running with admin permissions it should not ask for them anymore.

Testing notes:

You will need to create 2 different versions of installer.

  1. Create installer beta.4 with this PR
  2. Create installer beta.5 (should not matter if has this PR)
  3. Install beta.4 to Program Files
  4. Upload beta.5 to server, set it to be used in a bundle, set the bundle as production
  5. Run beta.4
  6. An update should start which should ask for permissions if required

@iLLiCiTiT iLLiCiTiT changed the title Windows: Ask for admin permissions when required Windows auto-update: Ask for admin permissions when required Aug 21, 2023
@iLLiCiTiT iLLiCiTiT requested a review from m-u-r-p-h-y August 21, 2023 13:30
m-u-r-p-h-y
m-u-r-p-h-y approved these changes Aug 21, 2023
View reviewed changes
Copy link
Member

@m-u-r-p-h-y m-u-r-p-h-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the installer downloaded from the server correctly asks for elevated permissions.

@iLLiCiTiT iLLiCiTiT merged commit bd10ba4 into develop Aug 21, 2023
@iLLiCiTiT iLLiCiTiT deleted the enhancement/ask-for-admin-permissions branch August 21, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-u-r-p-h-y m-u-r-p-h-y m-u-r-p-h-y approved these changes

Assignees

@m-u-r-p-h-y m-u-r-p-h-y

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iLLiCiTiT @m-u-r-p-h-y