Executable version lookup fix #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…executable did not change
kalisp
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Fixed issues with lookup for version of AYON launcher.
Additional info
Stored launcher versions are validated once in 2 days. The validation happens automatically on launch. When existing version of AYON launcher is found out, the launcher must contain
version.pywith correct version -> in other word version in metadata has no value for automated lookup of AYON launcher versions. Cleanup function was fixed to work as expected.The issue was that if anyone would start ayon from the same location and the launched version would not be demanded version by server, and the demanded version would point to the same executable, it would cause infinite start of ayon processes.
Testing notes:
Hard to tell how to test.
%\Ynput\AYON\executables.jsonshould contain less informarmation if there was before more of them.