Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show message about missing requirements #34

Merged
merged 3 commits into from
Aug 16, 2023

Conversation

iLLiCiTiT
Copy link
Member

Changelog Description

Tell user that he's missing openpype addon or dependency package is missing.

Additional info

Both checks are based on guessing based on import from openpype. openpype.PACKAGE_DIR does not require any dependencies from python -> good to test if openpype is available. openpype.cli has requirements for dependencies -> good way to test if dependency package is missing or invalid.

Testing notes:

Missing openpype

  1. Make invalid bundle without openpype
  2. Start ayon launcher
  3. A message should pop up

Missing dependency package

  1. Make invalid bundle without dependency package
  2. Start ayon launcher
  3. A message should pop up

@iLLiCiTiT iLLiCiTiT added the type: enhancement Improvement of existing functionality or minor addition label Aug 11, 2023
@iLLiCiTiT iLLiCiTiT changed the title UI: Show message about missing requirements Show message about missing requirements Aug 11, 2023
Copy link
Member

@kalisp kalisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Throws both warnings correctly:
AnyDeskMSI_QCUkFsBhBe
AnyDeskMSI_tI5oiOCbuK

@iLLiCiTiT iLLiCiTiT merged commit 61b10de into develop Aug 16, 2023
@iLLiCiTiT iLLiCiTiT deleted the enhancement/missing-requirements-message branch August 16, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants