Make installer script modification #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iLLiCiTiT
added
the
type: enhancement
Minkiu
reviewed
Aug 2, 2023
|
|
||
|
|
||
| def create_installer(ayon_root, build_root): | ||
| metadata = get_build_metadata(build_root) | ||
| ayon_version = metadata["version"] | ||
| build_content_root = get_build_content_root(build_root, ayon_version) | ||
| installer_root = build_root / "installer" | ||
| if installer_root.exists(): | ||
| shutil.rmtree(str(installer_root)) |
There was a problem hiding this comment.
Maybe we should add a flag for this? Imagine we are creating several versions (or platforms), you would have to move them form the output before triggering this again, right?
There was a problem hiding this comment.
Agree, but in future PR. It would mean more changes.
Minkiu
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Modified make installer to create installer in subdir
build/installer/which will contain installer file and metadata json ready for AYON server. Removedcreate-server-packagecommand which does not have real usage for deployment.Testing notes:
Everything should work as before this PR.
buildcommandmake-installercommanduploadcommandThe only difference is that installer is nested subfolder
./build/installer/.