Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Add distro and pyside2 information to installer filename #158

Merged
merged 5 commits into from
Aug 29, 2024

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Aug 29, 2024

Changelog Description

Installer filename contains information about used pyside2 and on linux also contains distribution short .

Additional info

It is PITA to find out for which distribution was laucher created and if was created with pyside2 or pyside6, this should help a little. Server still does support only one linux installer, but at least we're able to find out which is used.

Testing notes:

  1. Create linux installer.
  2. Filename should automatically contain distro name.
  3. If --use-pyside2 is used, the filename also contains -pyside2.

Resolves #128

@iLLiCiTiT iLLiCiTiT merged commit b745f81 into develop Aug 29, 2024
1 check passed
@iLLiCiTiT iLLiCiTiT deleted the enhancement/add-distro-and-pyside2-info branch August 29, 2024 10:42
@fabiaserra
Copy link

You missed adding distro_short argument to the _find_matching_installer function too, otherwise:

Traceback (most recent call last):
  File "/builds/coreweave/pipeline/ayon/ayon-launcher/tools/installer_post_process.py", line 363, in <module>
    main()
  File "/builds/coreweave/pipeline/ayon/ayon-launcher/tools/installer_post_process.py", line 347, in main
    func(**result_dict)
  File "/builds/coreweave/pipeline/ayon/ayon-launcher/tools/installer_post_process.py", line 243, in cli_upload
    create_installer(api, installer_info, force)
  File "/builds/coreweave/pipeline/ayon/ayon-launcher/tools/installer_post_process.py", line 185, in create_installer
    matched_installer = _find_matching_installer(api, installer_info)
  File "/builds/coreweave/pipeline/ayon/ayon-launcher/tools/installer_post_process.py", line 166, in _find_matching_installer
    return InstallerInfo(
TypeError: __init__() missing 1 required positional argument: 'distro_short'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linux build and installer information
4 participants