Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webactions: Validate used user #132

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Jul 31, 2024

Changelog Description

AYON launcher validates that the user who triggered the action is the one logged in AYON launcher.

Additional info

This should handle an edge case that 2 different users trigger webaction on the same machine. In that case it should ask for logic of the user who triggered the action.

Testing notes:

  • Step 1: Use different user from currently logged in user.
  1. Prepare user1 and user2 on AYON server.
  2. Login in AYON launcher to user1.
  3. Login to AYON server as user2 and trigger webaction.
  4. AYON launcher should ask to login, and will force to use the username.
  • Step 2: Use 'Login with AYON server' button
  1. In tray logout from AYON launcher.
  2. In default browser log as user1, in second browser (e.g. Edge, Chrome) log as user2.
  3. Start webaction from the second browser.
  4. AYON login dialog should show up, use Login with AYON server button.
  5. Confirm in default browser.
  6. AYON launcher dialog should tell you that different user was used.

@ynbot
Copy link

ynbot commented Jul 31, 2024

@iLLiCiTiT iLLiCiTiT requested review from BigRoy and antirotor July 31, 2024 09:42
@iLLiCiTiT iLLiCiTiT changed the base branch from feature/AY-5077_AYON-launcher-shims to feature/AY-5950_AYON-Launcher-handle-webactions July 31, 2024 09:43
@ynbot
Copy link

ynbot commented Jul 31, 2024

Task linked: AY-5950 AYON Launcher handle webactions

…eature/AY-6020_Validate-that-logged-user-is-the-same-as-the-user-who-triggered-action
@iLLiCiTiT iLLiCiTiT changed the base branch from feature/AY-5950_AYON-Launcher-handle-webactions to feature/AY-5077_AYON-launcher-shims August 1, 2024 13:57
…20_Validate-that-logged-user-is-the-same-as-the-user-who-triggered-action
…20_Validate-that-logged-user-is-the-same-as-the-user-who-triggered-action

# Conflicts:
#	common/ayon_common/connection/ui/login_window.py
#	start.py
@iLLiCiTiT iLLiCiTiT requested review from 64qam and MilaKudr August 6, 2024 15:02
@iLLiCiTiT iLLiCiTiT added the type: enhancement Improvement of existing functionality or minor addition label Aug 6, 2024
@iLLiCiTiT iLLiCiTiT merged commit 8081676 into feature/AY-5077_AYON-launcher-shims Aug 7, 2024
@iLLiCiTiT iLLiCiTiT deleted the feature/AY-6020_Validate-that-logged-user-is-the-same-as-the-user-who-triggered-action branch August 7, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants