-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linux Qt binding granurality #127
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do the same for centos7 by adding |
iLLiCiTiT
reviewed
Jul 16, 2024
iLLiCiTiT
reviewed
Jul 16, 2024
Co-authored-by: Jakub Trllo <[email protected]>
1 task
Modified the original PR to be able to build any linux installer with PySide2. |
64qam
approved these changes
Jul 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works at client's end
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MODIFIED BY @iLLiCiTiT
Changelog Description
Added
distro
python module to detect linux distribution name used for detection of Qt binding. Also added option to use PySide2 during docker build.Source issue
Rocky 8 might not support PySide6 by default and that might require to use PySide2 instead of PySide6. That was case because of specific rocky 8 state and GPU drivers. For now that is considered as edge case as most of machines should use PySide6 by rather.
Error