Wepublisher: use service account to query secrets #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Used to query Ftrack secrets from Settings, as regular artist doesn't have enough permissions
Regular artist user doesn't have enought permissions to use secrets. WP service (or better ASH) must be triggered by some service account to connect to the server.
kalisp
added
type: bug
iLLiCiTiT
reviewed
Dec 18, 2024
client/ayon_ftrack/plugins/publish/collect_webpublisher_credentials.py
Outdated
Show resolved
Hide resolved
iLLiCiTiT
reviewed
Dec 18, 2024
client/ayon_ftrack/plugins/publish/collect_webpublisher_credentials.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Jakub Trllo <[email protected]>
None will fallback to AYON_API_KEY value
…lectWebpublisherCredentials-requires-access-to-secrets' into bugfix/AY-7276_Webpublishers-CollectWebpublisherCredentials-requires-access-to-secrets
This reverts commit 784c7ad.
iLLiCiTiT
approved these changes
Dec 18, 2024
64qam
approved these changes
Dec 18, 2024
kalisp
deleted the
bugfix/AY-7276_Webpublishers-CollectWebpublisherCredentials-requires-access-to-secrets
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Previous implementation was using regular (current) AYON account which failed for non admin accounts (
artist,freelancer).This uses wrapper for service account which is used to start ASH worker.
Testing notes: