Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process preparation: Ftrack addon can ensure that is process ready #109

Merged

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Jul 17, 2024

Description

Feature which makes sure that user is logged in when a process is being prepared for pipeline usage.

Additional information

Addon ftrack make sure user is logged in when another addon requests it. This can be used e.g. on application launch. The PR is dependent on ayon-core PR which is not yet created.

PRs requires

TODO

Bump requested ayon-core version based on when this PR is merged and new ayon-core is released.

Testing notes

  1. If process request process prepration, ftrack will request login of user if is not yet logged in.

@ynbot
Copy link
Contributor

ynbot commented Jul 17, 2024

@iLLiCiTiT iLLiCiTiT marked this pull request as ready for review July 30, 2024 12:46
Comment on lines 239 to 240
"Ftrack credentials are not set. Cannot handle the situation"
" in headless mode."
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs some artist friendly message. Marking @BigRoy and @mkolar for suggestions.

return

raise ProcessPreparationError(
"Failed to log to ftrack. Cannot continue with the process."
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs some artist friendly message. Marking @BigRoy and @mkolar for suggestions.

@64qam 64qam requested a review from MilaKudr July 30, 2024 16:50
return

raise ProcessPreparationError(
"Failed to log to ftrack. Cannot continue with the process."
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Failed to log to ftrack. Cannot continue with the process."
"Unable to connect to Ftrack. The process cannot proceed without this connection."

Comment on lines 239 to 240
"Ftrack credentials are not set. Cannot handle the situation"
" in headless mode."
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Ftrack credentials are not set. Cannot handle the situation"
" in headless mode."
"Ftrack login details are missing. Unable to proceed without a user interface."

@iLLiCiTiT iLLiCiTiT merged commit 2e67611 into develop Aug 21, 2024
1 check passed
@iLLiCiTiT iLLiCiTiT deleted the feature/AY-6023_Addon-ftrack-implements-addon-initialization branch August 21, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants